8000 fix(api): delete old workflow data tables (#4677) · ovh/cds@05c6aec · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Commit 05c6aec

Browse files
authored
fix(api): delete old workflow data tables (#4677)
1 parent f78b1ec commit 05c6aec

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

engine/api/workflow/dao.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -942,13 +942,19 @@ func Update(ctx context.Context, db gorp.SqlExecutor, store cache.Store, w *sdk.
942942
}
943943

944944
// Delete workflow data
945-
if uptOption.OldWorkflow != nil {
945+
if uptOption.OldWorkflow != nil && uptOption.OldWorkflow.ID != 0 {
946946
if err := DeleteWorkflowData(db, *uptOption.OldWorkflow); err != nil {
947947
return sdk.WrapError(err, "unable to delete from old workflow data(%d - %s)", w.ID, w.Name)
948948
}
949949
} else {
950-
if err := DeleteWorkflowData(db, *w); err != nil {
951-
return sdk.WrapError(err, "unable to delete from workflow data(%d - %s)", w.ID, w.Name)
950+
oldW, err := Load(ctx, db, store, p, w.Name, u, LoadOptions{})
951+
if err != nil && !sdk.ErrorIs(err, sdk.ErrWorkflowNotFound) {
952+
return sdk.WrapError(err, "unable to load old workflow to delete workflow data")
953+
}
954+
if err == nil {
955+
if err := DeleteWorkflowData(db, *oldW); err != nil {
956+
return sdk.WrapError(err, "unable to delete from workflow data(%d - %s)", oldW.ID, oldW.Name)
957+
}
952958
}
953959
}
954960

0 commit comments

Comments
 (0)
0