8000 fix(ui): link was missing in artifact list since refact (#4353) · ovh/cds@01ed237 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Commit 01ed237

Browse files
richardltsguiheux
richardlt
authored and
sguiheux
committed
fix(ui): link was missing in artifact list since refact (#4353)
1 parent a00966a commit 01ed237

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

‎ui/src/app/shared/table/data-table.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const DESC: direction = 'desc';
88
export enum ColumnType {
99
TEXT = 'text',
1010
ICON = 'icon',
11+
LINK_CLICK = 'link-click',
1112
LINK = 'link',
1213
ROUTER_LINK = 'router-link',
1314
ROUTER_LINK_WITH_ICONS = 'router-link-with-icons',

‎ui/src/app/shared/table/data-table.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@
5858
<a *ngSwitchCase="'router-link'" class="ui" [routerLink]="c.selector.link">
5959
{{c.selector.value}}
6060
</a>
61-
<a *ngSwitchCase="'link'" class="ui pointing" (click)="c.selector.callback()">
61+
<a *ngSwitchCase="'link-click'" class="ui pointing" (click)="c.selector.callback()">
62+
{{c.selector.value}}
63+
</a>
64+
<a *ngSwitchCase="'link'" class="ui pointing" [href]="c.selector.link" target="_blank">
6265
{{c.selector.value}}
6366
</a>
6467
<markdown *ngSwitchCase="'markdown'" [data]="c.selector"></markdown>
@@ -105,4 +108,4 @@
105108
</td>
106109
</tr>
107110
</tfoot>
108-
</table>
111+
</table>

‎ui/src/app/views/admin/hook-task/show/hook-task.show.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export class HookTaskShowComponent {
6161
}
6262
},
6363
<Column<TaskExecution>>{
64-
type: ColumnType.LINK,
64+
type: ColumnType.LINK_CLICK,
6565
name: 'action',
6666
selector: (d: TaskExecution) => {
6767
return {

0 commit comments

Comments
 (0)
0