feat(worker): add static-key to keep the same public url for serve static files (close #3657) #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic files (close #3657) Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
yesnault
requested changes
Dec 3, 2018
golangcibot
reviewed
Dec 3, 2018
sdk/static_files.go
Outdated
| container := base64.RawURLEncoding.EncodeToString([]byte(fmt.Sprintf("%d-%s", staticfile.NodeJobRunID, url.PathEscape(staticfile.Name)))) | ||
| var container string | ||
| if staticfile.StaticKey != "" { | ||
| container = base64.RawURLEncoding.EncodeToString([]byte(fmt.Sprintf("%d-%d-%s", staticfile.WorkflowID, staticfile.StaticKey, url.PathEscape(staticfile.Name)))) |
There was a problem hiding this comment.
Sprintf format %d has arg staticfile.StaticKey of wrong type string (from govet)
yesnault
requested changes
Dec 3, 2018
richardlt
reviewed
Dec 3, 2018
…atic files (close #3657) Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
yesnault
approved these changes
Dec 3, 2018
…atic files (close #3657) Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
fsamin
approved these changes
Dec 3, 2018
sguiheux
approved these changes
Dec 3, 2018
richardlt
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com
close Serve Static Files with a fix url #3657
@ovh/cds