feat(integration/s3): tempURL, cache, doc, integration #4221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d4c6bd to
f1c81f4
Compare
|
new IT: |
Signed-off-by: Yvonnick Esnault <yvonnick@esnau.lt>
f1c81f4 to
69e977e
Compare
bnjjj
suggested changes
Apr 29, 2019
| - action [Artifact Downlaod]({{< relref "/docs/actions/artifact-download.md">}}) | ||
| - [worker cache command]({{< relref "/docs/components/worker/cache">}}) | ||
|
|
||
| Notice: per default, the storage is configured in CDS Configuration. This integration |
There was a problem hiding this comment.
by default instead per default no ?
| With this integration, you can use a dedicated AWS S3 Bucket Storage on : | ||
|
|
||
| - action [Artifact Upload]({{< relref "/docs/actions/artifact-upload.md">}}) | ||
| - action [Artifact Downlaod]({{< relref "/docs/actions/artifact-download.md">}}) |
There was a problem hiding this comment.
Suggested change
| - action [Artifact Downlaod]({{< relref "/docs/actions/artifact-download.md">}}) | |
| - action [Artifact Download]({{< relref "/docs/actions/artifact-download.md">}}) |
| if err != nil 8000 { | ||
| return "", "", sdk.WrapError(err, "failed to sign request") | ||
| } | ||
| log.Debug("AWS-S3-Store> StoreURL urlStr:%v key:%v hs:%v", urlStr, *key, hs) |
yesnault
added a commit
that referenced
this pull request
Apr 29, 2019
* feat(integration/s3): tempURL, cache, docs Signed-off-by: Yvonnick Esnault <yvonnick@esnau.lt> Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
yesnault
added a commit
that referenced
this pull request
Apr 29, 2019
* feat(integration/s3): tempURL, cache, docs Signed-off-by: Yvonnick Esnault <yvonnick@esnau.lt> Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yvonnick Esnault yvonnick@esnau.lt