8000 OIDC token validation using issuer public key (CADC-13465) by andamian · Pull Request #172 · opencadc/ac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

OIDC token validation using issuer public key (CADC-13465) #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

OIDC token validation using issuer public key (CADC-13465) #172

wants to merge 13 commits into from

Conversation

andamian
Copy link
Contributor

No description provided.

@brianmajor brianmajor requested a review from pdowler September 17, 2024 17:52
@brianmajor
Copy link
Member

@pdowler - Should we review and merge this?

@pdowler
Copy link
Member
pdowler commented Sep 17, 2024

will review once the build passes

pdowler
pdowler requested changes Oct 3, 2024
View reviewed changes
Copy link
Member
@pdowler pdowler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the merge conflict is resolved, at least some of the extra code here should be moved into OIDCClient so it can benefit from the cached openid-configuration

pdowler
pdowler requested changes Nov 7, 2024
View reviewed changes
Copy link
Member
@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the StandardIdentityManager intTest, you will see that if you create a file with a valid token (from the provider in the intTest/resources/cadc-registry.properties) you can test this... did you notice that and try it?

pdowler
pdowler previously approved these changes Nov 8, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdowler pdowler pdowler left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andamian @brianmajor @pdowler
0