8000 Wrong variables declaration location in functions / procedures / actions · Issue #10 · orcc/orc-apps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Wrong variables declaration location in functions / procedures / actions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alorence opened this issue Apr 5, 2013 · 1 comment
Closed

Comments

@alorence
Copy link
Contributor
alorence commented Apr 5, 2013

As mentionned at iv) point on issue orcc/orcc#42, until now Orcc allowed to declare variables in the body of a procedure (or function / action). This is not correct regarding on CAL standard.

A patch to fix this behaviour is ready (see orcc/orcc@6d680800), but before merging it to the master branch, all projects in orc-apps repository should be fixed.

The way to fix is pretty simple but a bit long to perform:
In all actions / functions / procedures, each local variable must be declared in a 'var' block instead of in the body. Each variable declaration must be separated by a comma, instead of a semi-colon.

alorence added a commit that referenced this issue Aug 27, 2013
As explained in issue #10, all CAL actors should declare local
variables only in a 'var' block and not anymore in the first
statements of the body
alorence added a commit that referenced this issue Aug 28, 2013
As explained in issue #10, all CAL actors should declare local
variables only in a 'var' block and not anymore in the first
statements of the body
alorence added a commit that referenced this issue Aug 28, 2013
As explained in issue #10, all CAL actors should declare local
variables only in a 'var' block and not anymore in the first
statements of the body
@alorence
Copy link
Contributor Author

Main branches have been updated to fix this issue. I close the ticket, since other branches can easily be fixed by cherry picking one of the three above commits (you can cherry-pick the closest and manually fix other few actors if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant
0