8000 Align with dotnet SDK API standards · Issue #189 · oras-project/oras-dotnet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Align with dotnet SDK API standards #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #36
sajayantony opened this issue Mar 20, 2025 · 0 comments · Fixed by #190
Open
Tracked by #36

Align with dotnet SDK API standards #189

sajayantony opened this issue Mar 20, 2025 · 0 comments · Fixed by #190
Labels
enhancement New feature or request
Milestone
v0.4.0

Comments

@sajayantony
Copy link
Contributor

The methods for referrers should potentially use a verb similar to Get/Fetch.
Here is an example -

oras-dotnet/src/OrasProject.Oras/Registry/Remote/Repository.cs

Line 547 in 7f1466f

internal async IAsyncEnumerable<Descriptor> ReferrersByTagSchema(Descriptor descriptor, string? artifactType,

I would look at other methods that deviate from the common dotnet conventions before we release this SDK.

Also another area is to avoid passing in null artifact type and actually have a method that doesn't support filtering an done that does to avoid having users pass in a magic null for filtering.
@pat-pan pat-pan mentioned this issue Mar 21, 2025
Merged
4 tasks
@sajayantony sajayantony added the triage New issues or PRs to be acknowledged by maintainers label Mar 24, 2025
@Wwwsylvia Wwwsylvia reopened this Mar 25, 2025
@Wwwsylvia Wwwsylvia mentioned this issue May 22, 2025
Open
49 tasks
@Wwwsylvia Wwwsylvia added enhancement New feature or request and removed triage New issues or PRs to be acknowledged by maintainers labels May 22, 2025
@Wwwsylvia Wwwsylvia added this to the v0.4.0 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

refactor!: refactor code to align with dotnet standards pat-pan/oras-dotnet
2 participants
@sajayantony @Wwwsylvia
0