Use dispatch(Command) in Room.onAuth() #567

ChristopherWalz · 2023-05-04T18:55:17Z

ChristopherWalz
May 4, 2023

My onAuth method currently looks like this:

    async onAuth(client: Client, options: any, request?: IncomingMessage) {
        if (!config.enableTwitchAuth) {
            return true;
        }

        const accessToken = options.accessToken || '';

        // empty access token, immediately return false
        if (accessToken === '') {
            return false;
        }

        const result = await this.validateAccessToken(accessToken);

        if (!result.success) {
            return false;
        }

        if (await this.isInAnyAnotherRoom(result.twitchData.userId)) {
            return false;
        }

        return result;
    }

I am currently trying to put this code into a seperate command like described here.

So I created a new class:

import {Command} from "@colyseus/command";
import {MyRoom} from "../test-room/my-room";
import config from "../config";

export class OnAuthCommand extends Command<MyRoom, {
	options
}> {

	async execute({ options }) {
		if (!config.enableTwitchAuth) {
			return true;
		}

		const accessToken = options.accessToken || '';

		// empty access token, immediately return false
		if (accessToken === '') {
			return false;
		}

		const result = await this.room.validateAccessToken(accessToken);

		if (!result.success) {
			return false;
		}

		if (await this.room.isInAnyAnotherRoom(result.twitchData.userId)) {
			return false;
		}

		return result;
	}
}

which I want to use like this:

    async onAuth(client: Client, options: any, request?: IncomingMessage) {
        return this.dispatcher.dispatch(new OnAuthCommand(), {
            options: options
        });
    }

which results in the following error:

TypeError: command.execute is not a function
    at Dispatcher.dispatch (/mnt/c/Repositories/foobar/server/node_modules/@colyseus/command/lib/index.js:
51:36)
    at Dispatcher.<anonymous> (/mnt/c/Repositories/foobar/server/node_modules/@colyseus/command/lib/index.
js:56:36)
    at Generator.next (<anonymous>)
    at /mnt/c/Repositories/foobar/server/node_modul
es/@colyseus/command/lib/index.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/mnt/c/Repositories/foobar/server
/node_modules/@colyseus/command/lib/index.js:4:12)     
    at /mnt/c/Repositories/foobar/server/node_modul
es/@colyseus/command/lib/index.js:53:55
    at processTicksAndRejections (node:internal/process
/task_queues:95:5)
    at MyRoom._onJoin (/mnt/c/Repositories/foobar/s
erver/node_modules/@colyseus/core/build/Room.js:302:23)
    at WebSocketServer.onConnection (/mnt/c/Repositorie
s/foobar/server/node_modules/@colyseus/ws-transport
/build/WebSocketTransport.js:104:7)

Is it possible to return a value with the Command pattern so I can use it in onAuth?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Colyseus

Use dispatch(Command) in Room.onAuth() #567

Uh oh!

{{title}}

Uh oh!

Replies: 0 comments

Select a reply

Uh oh!

Colyseus

Use dispatch(Command) in Room.onAuth() #567

Uh oh!

ChristopherWalz May 4, 2023

Replies: 0 comments

ChristopherWalz
May 4, 2023