8000 Adding a places rating system · Issue #11111 · osmandapp/OsmAnd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Adding a places rating system #11111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FinixFighter opened this issue Mar 11, 2021 · 33 comments
Open

Adding a places rating system #11111

FinixFighter opened this issue Mar 11, 2021 · 33 comments
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning

Comments

@FinixFighter
Copy link
FinixFighter commented Mar 11, 2021 •
edited
Loading

🚀 Rating/review system for places

Description

Users will be able to review a place by giving it a vote and a comment. They could also be able to add a photo.

Describe the solution you'd like

http://openplacereviews.org/ could do the job.
(using multiple services other than openplacereviews could be used, but this would increase complexity)
@vshcherb
Copy link
Member

True, we have already integrated place images (upload / display) and going to continue

@vshcherb vshcherb added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Mar 11, 2021
@vinber vinber mentioned this issue Mar 23, 2021
Open
@dyamon
Copy link
dyamon commented Jul 20, 2021

https://lib.reviews/ is also a cool project that might be worth looking into. It already has a basic support for reviewing OSM nodes.

@FinixFighter
Copy link
Author

https://lib.reviews/ is also a cool project that might be worth looking into. It already has a basic support for reviewing OSM nodes.

Displaying reviews from both https://lib.reviews/ and http://openplacereviews.org/ would be great.

@vshcherb
Copy link
Member

lib.reviews is very generic project, while openplacereviews is inmature but it starts solving main problem connecting OpenStreetMap ID with Permanent ID. Right now OpenPlaceReviews manages only Images associated with Permanent ID but once it becomes more stable and gets tools ready it will have Reviews as well.
While other Open Review projects don't have any connection with OSM id, so it's not possible to use them directly.

@dyamon
Copy link
dyamon commented Jul 21, 2021

I'm not sure I understand your reasoning here.

lib.reviews is very generic project

this is a non-problem. AFAIK they are generic so that they can potentially be adopted by a lot of different projects with different usecases. It is generic on their side and it won't be on OsmAnd side (I don't expect to be able to review or see reviews of books from OsmAnd, for example).

solving main problem connecting OpenStreetMap ID with Permanent ID

I don't think I'm completely up to date with this issue, but I think they are planning for an tighter integration with OSM anyway. At the moment they are using node/way URLs, but if that is the standard way to refer to an object in OSM, this will probably end up being the solution adopted by lib.reviews as well.

Still I understand that support for multiple services comes with more work and maintenance.

@dyamon
Copy link
dyamon commented Jul 29, 2021

@d4f5409d AFAIK there is no way to review POIs (with written reviews or, let's say, 1-5 star rating).

What you can do is to submit pictures for some POIs (mainly commercial activities like hotels, restaurants, pubs, bars) through OpenPlaceReviews, because that's what that project implemented so far.

@d4f5409d
Copy link

Cool! Well, I'm waiting for it. Then OSMAnd would be a real Google Maps competitor!

@pqhf5kd
Copy link
pqhf5kd commented Aug 7, 2021

Is the OpenPlaceReciews plug-in on iOS?

@vshcherb
Copy link
Member
vshcherb commented Aug 8, 2021

OpenPlaceReciews plug-in on iOS - it is not complete yet, it doesn't allow to upload images

1 similar comment
@vshcherb
Copy link
Member
vshcherb commented Aug 8, 2021

OpenPlaceReciews plug-in on iOS - it is not complete yet, it doesn't allow to upload images

@Thatoo
Copy link
Thatoo commented Aug 26, 2021 •
edited by DmitryAlexei
Loading

On Osmand 3.9.10, android 10, I can see the OpenPlaceReview plugin, I can enable it and I can login to my account in its own settings and then... I can't find how to use it. In map's settings, I don't see anything... Nothing appear on the map... I guess I'm missing a step. Any guidance would be appreciated.

@amenk
Copy link
Contributor
amenk commented Aug 26, 2021

Open a POI of a supported type (such as restaurant or hotel), scroll down to images, you can submit a photo to openplacereviews.

Actual reviews are AFAIK not yet supported.

@scaidermern
Copy link
Contributor
scaidermern commented Feb 9, 2023 •
edited
Loading

Since OpenPlaceReviews is pretty dead how about adding support for Open Reviews instead?

Quoting from their website:

Building an Open Data Ecosystem for reviews of places, companies, books, websites and more.

[...]
Open Data Ecosystem for Reviews, with the following guiding principles in mind:

 * Anyone can read and write reviews without censorship or monetary restrictions.
 * Anyone is free to develop different algorithms (including no algorithm) that help them make sense of the reviews. This includes both non-profit and for-profit purposes.
 * Anyone can develop applications which leverage the generic infrastructure while being well suited to the needs of their community.

The reviews infrastructure and dataset is hosted and maintained by a non-profit organisation.

Looks like MapComplete already has support for Open Reviews.

@amenk
Copy link
Contributor
amenk commented Feb 9, 2023 •
edited
Loading

Adding open reviews aka mangrove would be awesome

@vshcherb
Copy link
Member
vshcherb commented Feb 9, 2023

@scaidermern Open Reviews looks pretty dead as well, there are not enough reviews for Places I think.
Openplacereviews serves extra purpose by providing Unique ID for Places that joints old/new OSM ids. So rating/review system could be only implemented if there is enough users to write reviews, so far I don't see any open initiative to succeed.

@scaidermern
Copy link
Contributor

@scaidermern Open Reviews looks pretty dead as well, there are not enough reviews for Places I think.

Maybe that's because most apps don't support Open Reviews yet? Not sure.

Too few reviews is a typical chicken-and-egg problem.

@keorn
Copy link
keorn commented Feb 9, 2023

Open Reviews has been recently integrated with MapComplete thanks to @pietervdvn . While adoption is pretty slow, the API works and its not dead.

We have funding available, if maintainers are fine with it and if anyone is interested in adding this integration (or any other work related to open reviews). You can email me at hello@open-reviews.net to discuss.

@pietervdvn
Copy link
Contributor
pietervdvn commented Feb 9, 2023 •
edited
Loading

I have Mangeove.reviews integrated - not open-reviews.net

Edit: MapComplete indeed has an integration with Mangrove.reviews

@keorn
Copy link
keorn commented Feb 9, 2023

Right, sorry if there is some confusion in branding. mangrove.reviews is just a particular technology supported by Open Reviews Association - open-reviews.net. Same thing. I should have stuck to Mangrove Reviews name.

@pietervdvn
Copy link
Contributor

Oh, should have known by your username ;)

I eyeballed this, as OpenPlaceReviews and openReviews is a bit too similar... an I associate OsmAnd with the former.

@hermann-san
Copy link

Is a developer here who would like to develop a OSMand plug-in for Mangrove.reviews?
There is funding available to do so.

@derkrasseleo derkrasseleo mentioned this issue Apr 22, 2023
Open
@scaidermern scaidermern mentioned this issue Jun 20, 2023
Closed
@scaidermern scaidermern mentioned this issue Aug 19, 2023
Closed
@delavei
Copy link
delavei commented Aug 21, 2023

Is a developer here who would like to develop a OSMand plug-in for Mangrove.reviews? There is funding available to do so.

Hello, has anybody started working on this? I am thinking of starting, but I don't have too much free time, so if I would be able to do so partially instead of my regular job, it would certainly help. Who can I talk to more about this?

@hermann-san
Copy link

I don't know what's the current state with the plugin, but you may also want to check with https://open-reviews.net/about/

@keorn
Copy link
keorn commented Aug 23, 2023 •
edited
Loading

@delavei reached out via email, let's see if we can figure something out! We should make sure to align any works with maintainers here.

@derkrasseleo
Copy link
Contributor

Any updates on this? I think open-reviews.net (aka mangrove.reviews) and lib.reviews both seem possible to integrate into Osmand.

@keorn
Copy link
keorn commented Jan 15, 2024 •
edited
Loading

I had a chat with @delavei back then and offered a grant for the work, but he did not get back (I am guessing other things got in the way). Anyone interested still very welcome to get in touch!

@delavei
A3E2 Copy link
delavei commented Feb 12, 2024

Hello, I apologize, I found myself in quite a busy period because of work and personal projects and I won't be able to develop this plugin. Maybe if things clear out later in the year, I definitely have this in the back of my memory.

@pastk pastk mentioned this issue Feb 28, 2024
Open
@komali2
Copy link
komali2 commented Aug 19, 2024

I'm interested and open to helping and have a couple hours a week I can help. I'll see if anyone replies to me here that's more experienced because I don't want to prevent someone more experienced from thinking me working on it means they shouldn't - I'm about to look at the osmand codebase for the first time 😅

Anyway I'll note down what I learn and think about as I go along, with the goal of getting a PR sooner rather than later so more experienced people can guide me to good architectural decisions

@derkrasseleo
Copy link
Contributor

I'm interested and open to helping and have a couple hours a week I can help. I'll see if anyone replies to me here that's more experienced because I don't want to prevent someone more experienced from thinking me working on it means they shouldn't - I'm about to look at the osmand codebase for the first time 😅

Anyway I'll note down what I learn and think about as I go along, with the goal of getting a PR sooner rather than later so more experienced people can guide me to good architectural decisions

Let me know if you need someone for testing on android!

@komali2
Copy link
komali2 commented Aug 30, 2024

For those watching, I'm stuck at this step:

import android project and run module flavor android.OsmAnd``

In this guide: https://www.osmand.net/docs/technical/build-osmand/how-to-compile-the-android-version

I don't know what "run module" means, I don't know what a "flavor" is, and I don't know where to find the "module flavor" android.OsmAnd. I do have android studio running and I believe I have the project imported correctly. Any help would be great. I couldn't find an active developer chat (the matrix server is dead) so I'm asking here.

@yekibud
Copy link
yekibud commented Nov 25, 2024 •
edited
Loading

@komali2 were you ever able to find out how to get in contact with the dev team for noobie contributor support? The only chats I'm aware of are the language specific community Matrix channels like #OsmAndMaps:tchncs.de. I'm a little concerned because I would also like to contribute to a few features soon (including this one) but will probably be in the same situation you are. I would prefer to work on OSMAnd instead of OrganicMaps because it works better for me out-of-the-box.

@komali2
Copy link
komali2 commented Nov 26, 2024

@komali2 were you ever able to find out how to get in contact with the dev team for noobie contributor support? The only chats I'm aware of are the language specific community Matrix channels like #OsmAndMaps:tchncs.de. I'm a little concerned because I would also like to contribute to a few features soon (including this one) but will probably be in the same situation you are. I would prefer to work on OSMAnd instead of OrganicMaps because it works better for me out-of-the-box.

Unfortunately, no. I didn't really find a good place to quickly chat with more experienced devs on the project. Luckily Taiwan has a really strong OSM / FOSS mapping community so my plan was at some g0v hackathon to just ask someone to help me get started on the issue.

@mfuhrmann
Copy link
mfuhrmann commented Jun 3, 2025 •
edited
Loading

I think, the OSM community or projects should really be aligned on this. If users add reviews at provider A, it does not help if you get ratings presented from provider B.
I only know Mangrove since, I work a lot with MapComplete. And I really like how easy to use it is.

Ratings and also pictures as mentioned here is really important to get the non-nerd users into the big OSM game 💪

And I think such features, need to be set as standards. Having them in the default views in apps / web UIs will bring a lot benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0