8000 Loss of subpixel AA on soft-wrapped line · Issue #16889 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Loss of subpixel AA on soft-wrapped line #16889

Closed
1 task done
winstliu opened this issue Mar 6, 2018 · 9 comments · Fixed by #16943
Closed
1 task done

Loss of subpixel AA on soft-wrapped line #16889

winstliu opened this issue Mar 6, 2018 · 9 comments · Fixed by #16943
Labels
editor-rendering more-information-needed

Comments

@winstliu
Copy link
Contributor
winstliu commented Mar 6, 2018

Prerequisites

Description

This is a followup to #16595. I tried replacing Math.ceil with both ceilToPhysicalPixelBoundary and roundToPhysicalPixelBoundary but neither fixed the issue I'm seeing.

Steps to Reproduce

  1. Open a file that is soft-wrapped at the edge of the screen
  2. On a new line, type characters until you are at the edge of the screen (i.e. right before soft-wrapping kicks in)

Expected behavior: Subpixel AA

Actual behavior: Subpixel AA is lost on the entire file

Reproduces how often: 100%

soft-wrap-subpixel-aa-loss
Sorry for the GIF quality. Had some troubles with Licecap + Magnifier interaction.

Versions

Atom    : 1.26.0-dev-e3a464ead
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0

Additional Information

Refs #16595

/cc @as-cii
@Ben3eeE
Copy link
Contributor
Ben3eeE commented Mar 6, 2018

@50Wliu What is your window.devicePixelRatio?

@winstliu
Copy link
Contributor Author
winstliu commented Mar 6, 2018

Can't believe I forgot to add that. It's 1.5.

@lee-dohm
Copy link
Contributor
lee-dohm commented Mar 7, 2018

@Ben3eeE Can you repro this?

/cc @as-cii

@Ben3eeE
Copy link
Contributor
Ben3eeE commented Mar 8, 2018 •
edited
Loading
  1. Open text-editor.js in Atom
  2. Copy the first 21 lines to a new untitled window
  3. Turn on soft wrapping and change language mode to javascript
  4. Resize the Window so it's soft wrapped
  5. On line 15 type a until the you reach the end of the window

Master build on: 429f2bd

My window.devicePixelRatio is 1

subpixel aa loss softwrap

@lee-dohm
Copy link
Contributor
lee-dohm commented Mar 8, 2018

Thanks very much @Ben3eeE 🙇

@revelt
Copy link
revelt commented Mar 9, 2018

White mice! It's Windows! I tried recreating this on Mac, no luck. It must be Windows-only issue.

Did you notice, M$ have never really, completely, nailed the antialiasing; they were meant to with original Longhorn plan but didn't make it. Gates had just took the foot off the pedal back then. And since then the issue became fossilised.

@as-cii as-cii mentioned this issue Mar 13, 2018
Merged
@as-cii as-cii self-assigned this Mar 13, 2018
@Ben3eeE Ben3eeE reopened this Mar 20, 2018
@Ben3eeE
Copy link
Contributor
Ben3eeE commented Mar 20, 2018 •
edited
Loading

We merged #16943 which improves this but it's still possible to reproduce when the edit is very near the edge of the window.

/cc: #16943 (comment)

Edit: Need to update the steps to reproduce to be for #16943 (comment) and confirm that what I see in this comment is the same issue or if this should be closed and a new issue opened. Labeling as more-information-needed for now until that is fixed.

@jasonrudolph jasonrudolph mentioned this issue May 8, 2018
Merged
60 tasks
@no-response no-response bot closed this as completed Oct 2, 2018
@no-response
Copy link
no-response bot commented Oct 2, 2018

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@daviwil daviwil mentioned this issue Dec 20, 2018
Merged
59 tasks
@lock
Copy link
lock bot commented Mar 31, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
editor-rendering more-information-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clip cursor width when soft-wrap is on and cursor is at the end of a line atom/atom
6 participants
@as-cii @lee-dohm @Ben3eeE @winstliu @revelt and others
0