Description
Problem
A couple of this repo's tests fail on Linux at the moment. The test failures look like this in CI:
1) Git commands for CompositeGitStrategy made of [GitShellOutStrategy]
exec
when the WorkerManager is not ready or disabled
kills the git process when cancel is triggered by the prompt server:
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/github/github/test/git-strategies.test.js)
2) Git commands for CompositeGitStrategy made of [GitShellOutStrategy]
ssh authentication
falls back to Atom credential prompts if SSH_ASKPASS is present but goes boom:
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/github/github/test/git-strategies.test.js)
And this one is flaky as well, not sure if related:
1) GitPromptServer
credential helper
preserves a provided username:
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/github/github/test/git-prompt-server.test.js)
Evidence narrowing it down to Electron 8+
I made some Atom builds and re-ran this repo's CI against those, essentially bisecting the Electron releases between Electron 6 (the last version this repo's CI passed on) and Electron 9 (the latest version used in Atom).
Results:
- 9 ❌: This repo's CI fails on its
masterbranch on Linux ❌; This is running against the official builds of Atom 1.59 Nightly and 1.58 Beta (both of which are built with Electron 9) (CI link). - 8 ❌: This repo's CI also fails on Linux ❌ when run with a custom build of Atom
master, built against Electron 8 (CI link). - 7 ✔️: The test failures go away ✔️ if testing against a custom build of Atom
masterusing Electron 7 (CI link) - 6 ✔️: or Electron 6 (CI link).
Conclusion: Something must have changed between Electron 7 and 8 that affects a few of this package's tests on Linux.
(Note 1: The last passing CI run at this repo was just before the Electron 9 PR landed at Atom: https://github.com/atom/github/actions/runs/611232541 ran just before atom/atom#21777 was merged. Note 2: This issue on Linux wouldn't be caught at the main Atom repo, because package tests only run on macOS at that repo.)