8000
ellie
force-pushed
the
ellie/fish-import-fix
branch
from
April 22, 2024 13:23
fix(dotfiles): fish alias import #1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
b34f7e0 to
6c9b6ea
Compare
|
Thanks! But it's still a bit broken: spaces are replaced with $ alias
alias please doas
alias x 'exa --icons --git --classify --group-directories-first'
$ atuin dotfiles alias import
Importing please=doas
Importing x='exa=--icons=--git=--classify=--group-directories-first'
$ atuin dotfiles alias list
please=doas
x='exa=--icons=--git=--classify=--group-directories-first' |
|
Ah, that's embarassing 🤦♀️ Fix in #1974. Sorry about that, should be good now. |
|
Yups, parsing works ok now! 🎉 |
|
Sorry, cheered too soon: it's now generating a bunch of errors on shell start :-( alias: -o: unknown option
alias: expected <= 2 arguments; got 3
alias: -u: unknown option
alias: expected <= 2 arguments; got 3
alias: --color=auto: unknown option
alias: -e: unknown option
alias: -e: unknown option
alias: -e: unknown option
alias: -p: unknown option
alias: -p: unknown option
alias: -p: unknown option
alias: -p: unknown option
alias: --autoremove: unknown option
alias: --recursive: unknown option
alias: --tree: unknown option
alias: --brief: unknown option
alias: expected <= 2 arguments; got 3
alias: expected <= 2 arguments; got 3
alias: expected <= 2 arguments; got 3
alias: --icons: unknown option
alias: -a: unknown option
alias: --icons: unknown option
alias: --no-mtime: unknown optionFrom these aliases: $ atuin dotfiles alias list
config='/usr/bin/git --git-dir=$HOME/.dotfiles.git/ --work-tree=$HOME'
docker-vabo='docker compose -p vabo -f /home/richard/src/php/vabo/ontwikkel/docker/docker compose.yml'
exa='exa --icons --level=2 --git --header'
fgrep='fgrep --color=auto'
gcm='git checkout master && git pull'
gfa='git fetch --all --prune --tags'
git_push_skip_ci='git push -o ci.skip'
gsu='git submodule update'
idl='python3 ~/src/instagram-media-downloader/instagram.py -u'
install='please apt install'
ip='ip --color=auto'
please=doas
po-artisan='docker compose exec -e PHP_IDE_CONFIG="serverName=po.test" beheer-72 php /project/beheer/artisan'
po-make='docker compose exec -e PHP_IDE_CONFIG="serverName=po.test" beheer-72 make'
po-run='docker compose exec -e PHP_IDE_CONFIG="serverName=po.test" beheer-72'
po2-artisan='docker compose -p po2 exec -e PHP_IDE_CONFIG="serverName=127.0.0.1" web php ./artisan'
po2-format='docker compose -p po2 exec web composer run format'
po2-run='docker compose -p po2 exec -e PHP_IDE_CONFIG="serverName=127.0.0.1" web'
po2-run-as-root='docker compose -p po2 exec -u root:root -e PHP_IDE_CONFIG="serverName=127.0.0.1" web'
remove='please apt purge --autoremove'
rsync='rsync --recursive --partial --progress --human-readable --info=progress2'
tree='exa --tree -L3 --classify --git --icons --group-directories-first'
uc='unicode --brief --max (math (tput lines) - 5) --regex'
update-bangle='ssh berilia "cd /var/www/BangleApps/bin/ && git pull && git submodule update && ./publish.sh"'
update-nella='ssh nella ./dockers/update-all.sh'
which=command
wine32='WINEARCH=win32 WINEPREFIX=$HOME/.wine32 wine'
x='exa --icons --git --classify --group-directories-first'
xa='x -a'
xdebug='export XDEBUG_CONFIG="remote_enable=1 remote_mode=req remote_port=9000 remote_host=127.0.0.1 remote_connect_back=0"'
xl='exa --icons --git --classify --long --header --group-directories-first'
ydl='youtube-dl --no-mtime --prefer-free-formats --audio-format opus --merge-output-format mp4' |
|
Does |
|
Looks like the opening/closing quotes got doubled for all aliases containing spaces: alias config=''/usr/bin/git --git-dir=$HOME/.dotfiles.git/ --work-tree=$HOME''
alias docker-vabo=''docker compose -p vabo -f /home/richard/src/php/vabo/ontwikkel/docker/docker compose.yml''
alias exa=''exa --icons --level=2 --git --header''
alias fgrep=''fgrep --color=auto''
alias gcm=''git checkout master && git pull''
alias gfa=''git fetch --all --prune --tags''
alias git_push_skip_ci=''git push -o ci.skip''
alias gsu=''git submodule update''
alias idl=''python3 ~/src/instagram-media-downloader/instagram.py -u''
alias install=''please apt install''
alias ip=''ip --color=auto''
alias please='doas'
alias po-artisan=''docker compose exec -e PHP_IDE_CONFIG="serverName=po.test" beheer-72 php /project/beheer/artisan''
alias po-make=''docker compose exec -e PHP_IDE_CONFIG="serverName=po.test" beheer-72 make''
alias po-run=''docker compose exec -e PHP_IDE_CONFIG="serverName=po.test" beheer-72''
alias po2-artisan=''docker compose -p po2 exec -e PHP_IDE_CONFIG="serverName=127.0.0.1" web php ./artisan''
alias po2-format=''docker compose -p po2 exec web composer run format''
alias po2-run=''docker compose -p po2 exec -e PHP_IDE_CONFIG="serverName=127.0.0.1" web''
alias po2-run-as-root=''docker compose -p po2 exec -u root:root -e PHP_IDE_CONFIG="serverName=127.0.0.1" web''
alias remove=''please apt purge --autoremove''
alias rsync=''rsync --recursive --partial --progress --human-readable --info=progress2''
alias tree=''exa --tree -L3 --classify --git --icons --group-directories-first''
alias uc=''unicode --brief --max (math (tput lines) - 5) --regex''
alias update-bangle=''ssh berilia "cd /var/www/BangleApps/bin/ && git pull && git submodule update && ./publish.sh"''
alias update-nella=''ssh nella ./dockers/update-all.sh''
alias which='command'
alias wine32=''WINEARCH=win32 WINEPREFIX=$HOME/.wine32 wine''
alias x=''exa --icons --git --classify --group-directories-first''
alias xa=''x -a''
alias xdebug=''export XDEBUG_CONFIG="remote_enable=1 remote_mode=req remote_port=9000 remote_host=127.0.0.1 remote_connect_back=0"''
alias xl=''exa --icons --git --classify --long --header --group-directories-first''
alias ydl=''youtube-dl --no-mtime --prefer-free-formats --audio-format opus --merge-output-format mp4'' |
|
For the record: quoting was fixed with bf88b42, fish aliases seem to work properly now 🎉 |
|
Wooo! Glad it's sorted 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks