8000 OpenID provider doesn't work in Python 3 · Issue #199 · authomatic/authomatic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

OpenID provider doesn't work in Python 3 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tommygod3 opened this issue Jun 24, 2019 · 3 comments
Open

OpenID provider doesn't work in Python 3 #199

tommygod3 opened this issue Jun 24, 2019 · 3 comments

Comments

@tommygod3
Copy link

The code gets a serialized association (a String) then attempts to decode it with:

authomatic/authomatic/providers/openid.py

Line 108 in e8b7c68

decoded = serialized.decode('latin-1')

This does not work in Python 3 as Strings do not need to be decoded.
Simple fix would be to remove this however more thought would need to be put it in to retain Python 2 compatibility I would imagine.
@jensens
Copy link
Member
jensens commented Jun 24, 2019

This could fix it:

# ...
import sys
PY2 = sys.version_info < (3, 0)
# ...

        assoc = association.serialize()
        if PY2
            assoc = assoc.decode('latin-1')
# ...

@tommygod3 tommygod3 mentioned this issue Jun 24, 2019
Open
@mrichar1
Copy link
Member

After several years of inactivity, authomatic is now under community management, and we have just released a new stable version (1.0.0).

We are now reviewing all issues and PRs and hoping to begin work to solve as many of these as 7EDF possible.

We are keen to find out which issues still apply, and which PRs are still required/are likely to merge cleanly into the current code. We are aiming to review them all, but any help with prioritisation would be very useful!

If you are still interested in having this issue/PR resolved, or are able to help us work on it, please reply to this message. That way we know which issues are most important to the community.

@tommygod3
Copy link
Author

I am not working on the project anymore where I found this bug but I am assuming that it's still an issue seeing as that file hasn't been changed sicne June 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jensens @mrichar1 @tommygod3
0