8000 Op in arma namespace · Issue #52 · awietek/xdiag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Op in arma namespace #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lukes118 opened this issue Apr 26, 2025 · 1 comment
Open

Op in arma namespace #52

lukes118 opened this issue Apr 26, 2025 · 1 comment

Comments

@lukes118
Copy link
Collaborator

Hey Alex,

The latest version of armadillo has a bug fix for expmat(), so I guess it would be nice if this was updated,

but now there is a clash with the namespaces as Op is now in the arma namespace,
I guess the appropriate fix to the examples would be,

using xdiag::Op; using arma::vec;

rather than simply,

using xdiag;
using arma;
@awietek
Copy link
Owner
awietek commented Apr 27, 2025

Thanks Luke for noticing this. This issue already existed with the previous version of armadillo. Op appears to be an internal class of armadillo and in my opinion should not have been exposed. I solved the issue at the time by adding the following two "evil hack style" lines on top of the armadillo header.

// Redifinition of "Op" to avoid name colission with xdiag::Op (#undef at bottom)
#define Op OPP

So if we update the armadillo which is included, we would need to add these two lines again as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awietek @lukes118
0