Description
Hi guys,
I noticed something that seems a bit unclear to me when comparing the version of a program in my system with the one in the Git repository. I'm hoping someone could help me understand it better—and perhaps this could also be considered for improvement.
Version of the program in my system:
REPORT zhello_world_v1.
CLASS zcl_hello_world DEFINITION.
PUBLIC SECTION.
METHODS: say_hello.
ENDCLASS.
CLASS zcl_hello_world IMPLEMENTATION.
METHOD say_hello.
cl_demo_output=>display( 'Hello, World!' ).
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(lo_hello) = NEW zcl_hello_world( ).
lo_hello->say_hello( ).
Version of the program in the Repository:
REPORT zhello_world_v1.
CLASS zcl_hello_world DEFINITION.
PUBLIC SECTION.
METHODS: say_hello.
ENDCLASS.
CLASS zcl_hello_world IMPLEMENTATION.
METHOD say_hello.
DATA(lv_name) = 'ABAP Developer'.
cl_demo_output=>display( |Hello, { lv_name }!| ).
ENDMETHOD.
ENDCLASS.
START-OF-SELECTION.
DATA(lo_hello) = NEW zcl_hello_world( ).
lo_hello->say_hello( ).
When I use the Unified view to compare these versions, I see:
In the Header: + 1 (green), - 0 (pink), ~ 1 (yellow)
In the Code:
1 pink line with a minus sign ( - ) on the left
2 green lines with plus sign ( + ) on the left
I was expecting something like:
Header: + 2 (green), - 1 (pink), and no ~ (yellow)
In the Split view, it looks like this:
In the Header: again + 1 (green), - 0 (pink), ~ 1 (yellow)
In the Code :
LOCAL side: 1 yellow line with ( ~ ) on the left and 1 green line with ( + ) on the left
REMOTE side: 1 yellow line with ( ~ ) on the left
Expectation: I would think this change could be reflected more clearly as 2 added lines (in green) and 1 removed line (in pink), rather than using the yellow color for changes. Header: +2 (green), -1 (pink), and no ~ (yellow)
Would it be possible to improve how these diffs are interpreted and displayed? Or provide some help on how to interpret these colors and header counts correctly?
Also, I think it makes more sense if the version in the system was labeled as "LOCAL", and the version in the Git repository as "REMOTE". This would help make the direction of change more intuitive when reviewing differences.
Best regards,
Francisco Milan.