8000 Remove *Sq classes · Issue #303 · acoular/acoular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content 8000
Remove *Sq classes #303
Open
Open
@adku1173

Description

@adku1173

@esarradj, @gherold

Is there anything against deprecating the BeamformerTimeSq class and all other *Sq classes in acoular.tbeamform?
The result functions have already been merged anyway to a single function in BeamformerTime and BeamformerTimeTraj and we currently have 4 extra classes implementing the sq logic.
Instead, we could introduce a squared_output / squared_result or simply sq attribute, which is False by default. r_diag would then only be able to be used when sq=True.

The only thing I am afraid of is that people think they apply "diagonal removal" but don't set the squared attribute to True. We could avoid this by changing the default value of r_diag to False and by printing a warning if r_diag==True and sq==False.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0