8000 Remove *Sq classes · Issue #303 · acoular/acoular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove *Sq classes #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adku1173 opened this issue Sep 11, 2024 · 1 comment
Open

Remove *Sq classes #303

adku1173 opened this issue Sep 11, 2024 · 1 comment
Labels
refactoring
Milestone
Refactoring (WP3)

Comments

@adku1173
Copy link
Member

@esarradj, @gherold

Is there anything against deprecating the BeamformerTimeSq class and all other *Sq classes in acoular.tbeamform?
The result functions have already been merged anyway to a single function in BeamformerTime and BeamformerTimeTraj and we currently have 4 extra classes implementing the sq logic.
Instead, we could introduce a squared_output / squared_result or simply sq attribute, which is False by default. r_diag would then only be able to be used when sq=True.

The only thing I am afraid of is that people think they apply "diagonal removal" but don't set the squared attribute to True. We could avoid this by changing the default value of r_diag to False and by printing a warning if r_diag==True and sq==False.
@esarradj
Copy link
Member

I think this change is unnecessary. The implementation of the *Sq classes is relatively lightweight and removing them has not much effect except breaking backwards compatibility.

@adku1173 adku1173 added this to the Release v24.10 milestone Sep 30, 2024
@esarradj esarradj mentioned this issue Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
Refactoring (WP3)
Development

No branches or pull requests
2 participants
@esarradj @adku1173
0