Open
Description
Is there anything against deprecating the BeamformerTimeSq
class and all other *Sq
classes in acoular.tbeamform
?
The result
functions have already been merged anyway to a single function in BeamformerTime
and BeamformerTimeTraj
and we currently have 4 extra classes implementing the sq logic.
Instead, we could introduce a squared_output
/ squared_result
or simply sq
attribute, which is False
by default. r_diag
would then only be able to be used when sq=True
.
The only thing I am afraid of is that people think they apply "diagonal removal" but don't set the squared attribute to True. We could avoid this by changing the default value of r_diag
to False
and by printing a warning if r_diag==True
and sq==False
.