inconsistent results for cylToCart and cartToCyl #378

adku1173 · 2024-11-29T09:17:42Z

Consider the following simple test in #377

def test_cart_cyl_transform():
    """Tests if transformation between cartesian and cylindrical coordinates are consistent."""
    original_cartesian = np.abs(np.random.RandomState(1).rand(3))
    converted_cartesian = ac.cylToCart(ac.cartToCyl(original_cartesian))
    np.testing.assert_allclose(converted_cartesian, original_cartesian)

Fails with output:

E           Mismatched elements: 2 / 3 (66.7%)
E           Max absolute difference: 0.30330249
E           Max relative difference: 0.72730572
E            x: array([7.203245e-01, 4.170220e-01, 1.143748e-04])
E            y: array([4.170220e-01, 7.203245e-01, 1.143748e-04])

The text was updated successfully, but these errors were encountered:

esarradj · 2024-11-29T17:07:04Z

This is indeed a bug in

acoular/acoular/environments.py

Line 140 in 17091b7

return array([x[1] * sin(x[0]), x[1] * cos(x[0]), x[2]])

where cos and sin need to be exchanged.

However, this is used in SpatialInterpolator so any bugfix it might affect its function. @gherold could you please check this?

adku1173 added the bug label Nov 29, 2024

esarradj assigned gherold Nov 29, 2024

adku1173 added this to the Refactoring milestone Jan 21, 2025

adku1173 mentioned this issue Mar 12, 2025

updates RotatingFlow class to feature "rotational_speed" #451

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

inconsistent results for cylToCart and cartToCyl #378

inconsistent results for cylToCart and cartToCyl #378

Uh oh!