8000 Added Remind me to save the backup key in onboarding while registration and in activity page. by anisha-e10 · Pull Request #3015 · acterglobal/a3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added Remind me to save the backup key in onboarding while registration and in activity page. #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 26, 2025
Merged

Added Remind me to save the backup key in onboarding while registration and in activity page. #3015

merged 18 commits into from
May 26, 2025

Conversation

anisha-e10
Copy link
Contributor
@anisha-e10 anisha-e10 commented May 23, 2025 •
edited
Loading

Implement, #3007

This PR introduces significant changes to the encryption key management flow during user onboarding and in the security and privacy settings area. The key enhancements are as follows:

1. Updated Onboarding Flow for Encryption Key

  • Replaced the existing "Next" and "Skip" buttons on the encryption key page with:
  1. "I saved the key securely": Navigates the user to the next onboarding step.
  2. "Remind me later": Triggers a confirmation dialog.
  • If the user clicks "Remind me about the key later" twice and confirms, the key is destroyed.

2. New Reminder Placement in Activity Page

  • A persistent reminder to store the encryption key is now shown under the Security & Privacy section of the Activity Page, visible only if the key is still available or has been reset via settings.

  • When users click "Show the key", they are shown a dialog with the option "Don't remind me again":

  • If selected, the key is destroyed.

3. Visual Feedback for Key Storage Status

  • The "Key Stored Securely" view changes color based on the key's status :

1. Normal (Default): Key not yet restored, but created within the last 2–3 days.
2. Warning: Key not securely stored between 3–7 days.
3. Critical (Red): Key not securely stored beyond 7 days.

Reference video (when user clicks i saved it for later):

Screen.Recording.2025-05-28.at.12.33.22.PM.mov

Reference video (when user clicks the remind me about later):

Screen.Recording.2025-05-28.at.12.37.41.PM.mov

Reference video (in activity when user clicks on don't remind me again):

Screen.Recording.2025-05-28.at.12.44.36.PM.mov

Reference video ( when user reset the key from setting then it user can see that key in activity):

Screen.Recording.2025-05-28.at.12.45.48.PM.mov

Reference image (when the user doesn't store securely for 2-3 days):

blue

Reference image (when the user doesn't store securely for 3-7 days):

yellow

Reference image (when the user doesn't store securely for 7+ days):

red

@github-project-automation github-project-automation bot moved this to Backlog in Product May 23, 2025
@codecov Codecov
Copy link
8000 codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.94574% with 22 lines in your changes missing coverage. Please review.

Project coverage is 41.49%. Comparing base (88177db) to head (c51d256).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...res/backups/providers/backup_manager_provider.dart 33.33% 4 Missing ⚠️
...atures/onboarding/pages/encrption_backup_page.dart 66.66% 4 Missing ⚠️
...res/activities/actions/destroy_enc_key_action.dart 76.92% 3 Missing ⚠️
..._and_privacy_section/show_recovery_key_widget.dart 90.00% 3 Missing ⚠️
...privacy_section/store_the_key_securely_widget.dart 88.46% 3 Missing ⚠️
...lib/features/activities/pages/activities_page.dart 0.00% 2 Missing ⚠️
...ckup_feature/widgets/encryption_backup_widget.dart 0.00% 2 Missing ⚠️
...atures/backups/dialogs/show_confirm_disabling.dart 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3015      +/-   ##
==========================================
+ Coverage   41.37%   41.49%   +0.12%     
==========================================
  Files         891      897       +6     
  Lines       56168    56299     +131     
==========================================
+ Hits        23237    23359     +122     
- Misses      32931    32940       +9
Flag Coverage Δ
integration-test 48.97% <ø> (-0.01%) ⬇️
unittest 31.64% <82.94%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anisha-e10 anisha-e10 marked this pull request as ready for review May 23, 2025 13:30
@gnunicorn
Copy link
Contributor
gnunicorn commented May 23, 2025 •
edited
Loading

"I saved the key securely": Navigates the user to the next onboarding step.
"Remind me later": Triggers a confirmation dialog.

If the user clicks "Remind me about the key later" twice and confirms, the key is destroyed.

This is the wrong way around. The dialog and destruction should happen on the "I saved the Key"-side of the flow. The "remind me later" should just be going ahead without any destruction.

@gnunicorn
Copy link
Contributor
gnunicorn commented May 23, 2025 •
edited by anisha-e10
Loading 
The "Key Stored Securely" view changes color based on the key's status:
  1. Normal (Default): Key not yet restored, but created within the last 2–3 days.
  2. Warning: Key not securely stored between 3–7 days.
  3. Critical (Red): Key not securely stored beyond 7 days.

Amazing!
Can we add that logic to the "Activity"-Information-marker as well? To not show it for the first three days, show it as a blue dot in case of a warning and as a yellow dot after (for critical)? That'd be grand.

gnunicorn
gnunicorn requested changes May 23, 2025
View reviewed changes
Copy link
Contributor
@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see the tests, but there are some logical and technical bugs that we need to address before we can merge this.

@anisha-e10
Copy link
Contributor Author

This is the wrong way around. The dialog and destruction should happen on the "I saved the Key"-side of the flow. The "remind me later" should just be going ahead without any destruction.

Ok, got it addressed in this commit

@anisha-e10 anisha-e10 requested a review from gnunicorn May 26, 2025 06:27
@anisha-e10 anisha-e10 merged commit dc6fe99 into main May 26, 2025
21 of 23 checks passed
@anisha-e10 anisha-e10 deleted the anisha/remindme-encryption-backup-key branch May 26, 2025 13:23
@github-project-automation github-project-automation bot moved this from Backlog to Recently Done in Product May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnunicorn gnunicorn gnunicorn approved these changes

@kumarpalsinh25 kumarpalsinh25 Awaiting requested review from kumarpalsinh25

@gtalha07 gtalha07 Awaiting requested review from gtalha07

Assignees
No one assigned
Labels
None yet
Projects
Product
Status: Recently Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anisha-e10 @gnunicorn
0