8000 Support Rails 5 · Issue #4177 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Support Rails 5 #4177
Closed
Closed
@seanlinsley

Description

@seanlinsley

#4175 got Rails 5 (master) running minimally on Travis. Currently it's breaking while building the test app, due to problems with our dependencies.

The Draper issue described on #4175 can be fixed by adding this line:

gem 'activemodel-serializers-xml', github: 'rails/activemodel-serializers-xml'

After that, I ran into this error, because Rails 5 automatically includes turbolinks in the application.js manifest file:

spec/rails/rails-5.0.0.alpha/app/assets/config/manifest.js:3: couldn't find file 'turbolinks' with type 'application/javascript' (Sprockets::FileNotFound)
  from spec/rails/rails-5.0.0.alpha/app/assets/javascripts/application.js:15
  from bundler/gems/sprockets-5a77f8b007b8/lib/sprockets/resolve.rb:58:in `resolve!'

Which can be fixed by adding it to the gemfile:

gem 'turbolinks'

Rerunning, I came across this issue with Devise:

gems/devise-3.5.2/lib/devise/failure_app.rb:9:in `<class:FailureApp>': uninitialized constant ActionController::RackDelegation (NameError)
  from gems/devise-3.5.2/lib/devise/failure_app.rb:8:in `<module:Devise>'
  from gems/devise-3.5.2/lib/devise/failure_app.rb:3:in `<top (required)>'
  from gems/devise-3.5.2/lib/devise/mapping.rb:122:in `default_failure_app'
  from gems/devise-3.5.2/lib/devise/mapping.rb:67:in `initialize'
  from gems/devise-3.5.2/lib/devise.rb:321:in `new'

It looks like Devise has a fairly large outstanding PR to support Rails 5: heartcombo/devise#3714, so we can use that branch for now:

gem 'devise', github: 'twalpole/devise', branch: 'rails5'

I then ran into this issue:

        rake    db:migrate db:test:prepare
rake aborted!
LoadError: cannot load such file -- rails/test_unit/sub_test_task
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:302:in `require'
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:302:in `block in require'
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:268:in `load_dependency'
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:302:in `require'
gems/draper-2.1.0/lib/draper/tasks/test.rake:7:in `<top (required)>'
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:296:in `load'
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:296:in `block in load'
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:268:in `load_dependency'
bundler/gems/rails-a8876760041f/activesupport/lib/active_support/dependencies.rb:296:in `load'
gems/draper-2.1.0/lib/draper/railtie.rb:67:in `block (2 levels) in <class:Railtie>'
gems/draper-2.1.0/lib/draper/railtie.rb:67:in `each'
gems/draper-2.1.0/lib/draper/railtie.rb:67:in `block in <class:Railtie>'

Which is an issue with Draper: drapergem/draper#681

That's as far as I've gotten. I just wanted to record my progress here. Once I actually have the test suite running without exceptions, I'll open a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0