8000 [Feature Request] Integrate logrotate configuration · Issue #44 · adelolmo/hd-idle · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature Request] Integrate logrotate configuration #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
auanasgheps opened this issue Mar 5, 2021 · 4 comments · Fixed by #47
Closed

[Feature Request] Integrate logrotate configuration #44

auanasgheps opened this issue Mar 5, 2021 · 4 comments · Fixed by #47
Labels
enhancement New feature or request

Comments

@auanasgheps
Copy link

Hi,
I think would be great if you could integrate the logrotate configuration for hd-idle, so when a user enables logs does not get flooded by them.

I don't know where to place the PR, so here's the config I'm using:
/etc/logrotate.d/hd-idle

/var/log/hd-idle.log {
      missingok
      notifempty
      compress
      delaycompress
}
@adelolmo adelolmo added the enhancement New feature or request label Mar 7, 2021
@adelolmo
Copy link
Owner
adelolmo commented Mar 7, 2021

This idea was already in my radar. I left it out of the last release, but I'm certainly will add it in the next one.

My internal debate was the following:

  • Since the log file is present in the default configuration, hd-idle should be responsible of rotate it.
  • Adding log rotation might brake installations where users do some statistics from the full log file.

So I still have to decide how best introduce rotation. (weekly, monthly, yearly, per size, etc)

@auanasgheps
Copy link
Author
auanasgheps commented Mar 7, 2021 •
edited
Loading

What you mean as "default" configuration? The example in the main page?

I can't remember where the config I posted comes from, but archives logs every week and keeps 4 weeks. It's pretty standard and works really well.

@adelolmo
Copy link
Owner
adelolmo commented Mar 8, 2021

What you mean as "default" configuration? The example in the main page?

This is the default log file.

I'll try your example (which is pretty similar to the original hd-idle rotation) and will definitely consider adding it on the next release.

@auanasgheps
Copy link
Author
auanasgheps commented Mar 8, 2021 •
edited
Loading

I guess is the same file, probably that's where I've taken the config file but I could not remember, makes sense now :)

@adelolmo adelolmo mentioned this issue Mar 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logrotate adelolmo/hd-idle
2 participants
@adelolmo @auanasgheps
0