8000 xml processor changing the names of strings can lead to conflicts · Issue #32 · adrielcafe/lyricist · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
< 8000 /react-partial>
xml processor changing the names of strings can lead to conflicts #32
Open
@dalewking

Description

@dalewking

I tried running the XML processor on our strings and ended up getting a conflict where the generated code had variables with the same name. After some digging I discovered what the problem is.

In our string files we ended up having 2 strings that were named almost the same

    <string name="pending_label">PENDING</string>
    <string name="pendingLabel">PENDING</string>

Oddly enough in 1 language they even had different translations.

Because the XML processor converts all the names to camel case they ended up being mapped to the same name which produced duplicate items both with the name pendingLabel.

The processor should at least detect such a conflict and handle it more appropriately than generating code that does not compile.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcodegen: android-xmlCodegen from Android String Resources conversion issue

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0