8000 should obb-collider component restore trackedObject3D's rotation instead of this.el.object3D's rotation in "updateBoundingBox" function? · Issue #5715 · aframevr/aframe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
should obb-collider component restore trackedObject3D's rotation instead of this.el.object3D's rotation in "updateBoundingBox" function? #5715
Open
@zakaton

Description

@zakaton

in the obb-collider component's updateBoundingBox function, it stores the trackedObject3D's rotation, but restores it by assigning it to this.el.object3D's rotation instead of trackedObject3D

I propose changing this section around line 162:

      // Restore rotations.
      trackedObject3D.parent.matrixWorld.compose(auxPosition, auxQuaternion, auxScale);
      this.el.object3D.rotation.copy(auxEuler); // issue - assigns it to this.el.object3D.rotation

to

      // Restore rotations.
      trackedObject3D.parent.matrixWorld.compose(auxPosition, auxQuaternion, auxScale);
      trackedObject3D.rotation.copy(auxEuler); // fix - assigns it to trackedObject3D

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0