8000 chore: remove ethers by atanmarko · Pull Request #45 · agglayer/interop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove ethers #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

chore: remove ethers #45

merged 2 commits into from
Jun 26, 2025

Conversation

atanmarko
Copy link
Collaborator
@atanmarko atanmarko commented Jun 23, 2025 •
edited
Loading

Fixes #43

Also removes some other unused dependencies.

@atanmarko atanmarko requested a review from a team as a code owner June 23, 2025 13:22
@atanmarko atanmarko requested review from iljakuklic and Ekleog-Polygon and removed request for a team June 23, 2025 13:22
@atanmarko atanmarko self-assigned this Jun 23, 2025
@atanmarko atanmarko added the agglayer-node Related to agglayer-node component label Jun 23, 2025
@atanmarko atanmarko added this to the v0.3.0 milestone Jun 23, 2025
@atanmarko atanmarko marked this pull request as draft June 23, 2025 13:46
@atanmarko atanmarko force-pushed the chore/remove-ethers branch from 08c7813 to 0c1ab90 Compare June 23, 2025 13:48
@atanmarko atanmarko force-pushed the chore/remove-ethers branch from 0c1ab90 to 31b7b51 Compare June 23, 2025 13:59
@atanmarko atanmarko marked this pull request as ready for review June 23, 2025 14:07
@Ekleog-Polygon Ekleog-Polygon mentioned this pull request Jun 24, 2025
Open
Ekleog-Polygon
Ekleog-Polygon reviewed Jun 24, 2025
View reviewed changes
Copy link
Collaborator
@Ekleog-Polygon Ekleog-Polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And now I'm sad to see that we're having so many totally unused dependencies 🥲 we should probably consider setting up cargo-udeps in CI so that these get auto-detected… I just opened #862 to track that

@atanmarko atanmarko merged commit 13eb2d2 into main Jun 26, 2025
15 checks passed
@atanmarko atanmarko deleted the chore/remove-ethers branch June 26, 2025 18:33
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog-Polygon Ekleog-Polygon Ekleog-Polygon left review comments

@iljakuklic iljakuklic iljakuklic approved these changes

Assignees

@atanmarko atanmarko

Labels
agglayer-node Related to agglayer-node component
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Remove ethers dependencies from interop
3 participants
@atanmarko @iljakuklic @Ekleog-Polygon
0