Open
Description
Hi,
From what I drew, I believe the code create_mask() should correct the padding indices.
From
eng_chars_to_padding_mask = np.arange(eng_sentence_length + 1, max_sequence_length)
kn_chars_to_padding_mask = np.arange(kn_sentence_length + 1, max_sequence_length)
to
eng_chars_to_padding_mask = np.arange(eng_sentence_length, max_sequence_length)
kn_chars_to_padding_mask = np.arange(kn_sentence_length , max_sequence_length)
Since np.arange generate a sequence from [start, end).
Correct me if I'm wrong, thank you!
Metadata
Metadata
Assignees
Labels
No labels