8000 Make NoEnterPlayer easier - revamp command structure · Issue #46 · akdukaan/GPFlags · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make NoEnterPlayer easier - revamp command structure #46

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akdukaan opened this issue Mar 25, 2023 · 1 comment
Open

Make NoEnterPlayer easier - revamp command structure #46

akdukaan opened this issue Mar 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@akdukaan
Copy link
Owner
akdukaan commented Mar 25, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

  • The number of bannable players in a NoEnterPlayer flag is limited by the number of characters you can send in a message
  • To add another player to the flag, you have to type all the players in the list again.

Describe the solution you'd like
The entire command format has to change maybe?

Important to recognize the three types of flags.

  • Boolean flags are either enabled or disabled and store no other information. For example, NoVehicle.
  • Single-input flags take in 1 input. For example, EnterMessage
  • Multi-input flags can take in 1 or more inputs. For example, NoEnterPlayer.

Biggest issue I’m trying to solve is that flags that are multi-input flags can’t be easily modified.

Also smaller issue: I don’t really like the word unset and I know a lot of people find it unintuitive. Could be replaced with something else. At the moment I’m thinking create and delete. Do provide feedback on the words to use but I want to focus the convo more on how param lists work.

To fix the smaller issue, im thinking to restructure the command so set and unset get pushed to come up later in the command structure.

Examples below. I think Boolean and single-input flags work well but I don’t yet love the way multi-inputs work

For Boolean flags:
/claimflag NoVehicle create
/claimflag NoVehicle delete

For single-input flags:
/claimflag EnterMessage create hello world
/claimflag EnterMessage delete

For multiinput flags:
/claimflag NoEnterPlayer create player1 — controversial removing the earlier ability to set multiple lines at the same time
/claimflag NoEnterPlayer add player2
/claimflag NoEnterPlayer remove 1 — removes line 1
/claimflag NoEnterPlayer info — shows which item is on which line
/claimflag NoEnterPlayer delete

would love some feedback from all GPF users
@akdukaan akdukaan added the enhancement New feature or request label Mar 25, 2023
@Techirion
Copy link

Add and Remove would work both for flags and lists?

Tho to be honest, it would be real nice if stuff like that would be GUI based...

A nice example would be TownyMenus, they use https://github.com/TownyAdvanced/TownyMenus/tree/main/src/main/java/io/github/townyadvanced/townymenus/gui + https://github.com/WesJD/AnvilGUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akdukaan @Techirion
0