8000 [Refactor][Enhancement] use Grpc replace all Http request between servers. · Issue #9949 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Refactor][Enhancement] use Grpc replace all Http request between servers. #9949

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
KomachiSion opened this issue Feb 14, 2023 · 2 comments
Closed
2 tasks done

[Refactor][Enhancement] use Grpc replace all Http request between servers. #9949

KomachiSion opened this issue Feb 14, 2023 · 2 comments
Assignees
@godhth
Labels
kind/enhancement Category issues or prs related to enhancement. kind/refactor
Milestone
2.2.1

Comments

@KomachiSion
Copy link
Collaborator
KomachiSion commented Feb 14, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

After Nacos 2.2, The server only can support upgrade from 2.0, and not support upgrade from 1.X. So the cluster default can support Grpc request in any situation.

But some of request like report between servers still use http, I think It should be replaced.

Describe the solution you'd like

  1. Add grpc request and response.
  2. modified the relative logic, use grpc to send request between servers default, if target node is unsupported, use http to request.
  3. mark the http server request and api as Deprecated.

Additional context

Expected report, also should find out other Http request between servers and do replaced.

  • replaced report API.
  • config-module, CommunicationController - remove datachange which has been replaced by grpc.
@KomachiSion KomachiSion added kind/refactor kind/enhancement Category issues or prs related to enhancement. labels Feb 14, 2023
@KomachiSion KomachiSion added this to the 2.2.1 milestone Feb 14, 2023
@godhth
Copy link
Contributor
godhth commented Feb 15, 2023

Please assigned replaced report API to me.

@godhth godhth mentioned this issue Feb 19, 2023
Merged
@KomachiSion KomachiSion mentioned this issue Feb 27, 2023
Closed
@Daydreamer-ia
Copy link
Contributor

please assigned remove dataChange task to me

@Daydreamer-ia Daydreamer-ia mentioned this issue Mar 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@godhth godhth

Labels
kind/enhancement Category issues or prs related to enhancement. kind/refactor
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
3 participants
@KomachiSion @godhth @Daydreamer-ia
0