[Bug]: compile error on macos #31

dourgulf · 2022-01-10T06:37:00Z

dourgulf
Jan 10, 2022

What happened?

execute cmake -j failed
ld: unknown option: --whole-archive
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libxquic.dylib] Error 1
make[1]: *** [CMakeFiles/xquic.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Steps To Reproduce

MacSs12.1; cmake version 3.22.0
follow readme compile with borningssl
execute cmake -j failed
ld: unknown option: --whole-archive
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libxquic.dylib] Error 1
make[1]: *** [CMakeFiles/xquic.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Relevant log output

ld: unknown option: --whole-archive
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libxquic.dylib] Error 1
make[1]: *** [CMakeFiles/xquic.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 90%] Built target xquic-static
make: *** [all] Error 2

dourgulf · 2022-01-10T06:38:59Z

dourgulf
Jan 10, 2022
Author

if I change CMakeLists.txt line 234
if(PLATFORM MATCHES "mac") to
if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
this error will be solved.

But i don't know how to change others like where:

    if(PLATFORM STREQUAL "mac32")
        target_link_libraries(test_server xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
        target_link_libraries(test_client xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
        target_link_libraries(demo_server xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
        target_link_libraries(demo_client xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
    elseif(PLATFORM STREQUAL "mac")
        target_link_libraries(test_server xquic -lm -L/usr/local/lib -levent)
        target_link_libraries(test_client xquic -lm -L/usr/local/lib -levent)
        target_link_libraries(demo_server xquic -lm -L/usr/local/lib -levent)
        target_link_libraries(demo_client xquic -lm -L/usr/local/lib -levent)
    else()
        target_link_libraries(test_server xquic -levent -lm)
        target_link_libraries(test_client xquic -levent -lm)
        target_link_libraries(demo_server xquic -levent -lm)
        target_link_libraries(demo_client xquic -levent -lm)
    endif()

1 reply

waruqi Jan 10, 2022

if I change CMakeLists.txt line 234 if(PLATFORM MATCHES "mac") to if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin") this error will be solved.

But i don't know how to change others like where:

    if(PLATFORM STREQUAL "mac32")
        target_link_libraries(test_server xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
        target_link_libraries(test_client xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
        target_link_libraries(demo_server xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
        target_link_libraries(demo_client xquic  -lm ${CMAKE_CURRENT_SOURCE_DIR}/../libevent32/lib/libevent.dylib)
    elseif(PLATFORM STREQUAL "mac")
        target_link_libraries(test_server xquic -lm -L/usr/local/lib -levent)
        target_link_libraries(test_client xquic -lm -L/usr/local/lib -levent)
        target_link_libraries(demo_server xquic -lm -L/usr/local/lib -levent)
        target_link_libraries(demo_client xquic -lm -L/usr/local/lib -levent)
    else()
        target_link_libraries(test_server xquic -levent -lm)
        target_link_libraries(test_client xquic -levent -lm)
        target_link_libraries(demo_server xquic -levent -lm)
        target_link_libraries(demo_client xquic -levent -lm)
    endif()

macos i386 has been deprecated, so I think we need only if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin") to detect it automatically amd remove mac32 if-block

ruiqizhou · 2022-01-10T07:08:50Z

ruiqizhou
Jan 10, 2022
Maintainer

Hi, try to use the cmake variables -DPLATFORM=mac to build xquic on MacOS as mentioned in https://github.com/alibaba/xquic/blob/main/docs/Platforms.md#macos-release. #12 Problem resolved after add -DPLATFORM=mac flag.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Bug]: compile error on macos #31

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 2 comments 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

[Bug]: compile error on macos #31

Uh oh!

Uh oh!

dourgulf Jan 10, 2022

What happened?

Steps To Reproduce

Relevant log output

Replies: 2 comments · 1 reply

Uh oh!

Uh oh!

dourgulf Jan 10, 2022 Author

Uh oh!

Uh oh!

waruqi Jan 10, 2022

Uh oh!

ruiqizhou Jan 10, 2022 Maintainer

dourgulf
Jan 10, 2022

Replies: 2 comments 1 reply

dourgulf
Jan 10, 2022
Author

ruiqizhou
Jan 10, 2022
Maintainer