8000 Better name for Alice.Router · Issue #60 · alice-bot/alice · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Better name for Alice.Router #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub < 8000 /a>

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adamzaninovich opened this issue Mar 26, 2016 · 2 comments
Open

Better name for Alice.Router #60

adamzaninovich opened this issue Mar 26, 2016 · 2 comments
Labels
breaking change Fixing this issue will require a breaking change enhancement

Comments

@adamzaninovich
Copy link
Member

It's confusing to have to type use Alice.Router in your handler. Maybe this would be better as use Alice.Handler.
@adamzaninovich
Copy link
Member Author

Possibly this change will keep Alice.Router and split up the routing and handler includes

@adamzaninovich adamzaninovich added this to the Alice v0.4 milestone Jun 16, 2016
@adamzaninovich adamzaninovich changed the title Rename Router to Handler Better name for Alice.Router Jun 17, 2016
@adamzaninovich adamzaninovich added the breaking change Fixing this issue will require a breaking change label Apr 11, 2020
@adamzaninovich adamzaninovich removed this from the Alice 2 milestone Apr 11, 2020
@NateBarnes
Copy link
Member

I concur that the routing functions should be split from the handler functions that get imported. I like the name Alice.Router for the actual routing functions that remain. Honestly I think you may be able to extract all the macros from Alice.Router and put them into an Alice.Handler. You might even be able to make it a non-breaking change by chaining the __using__ functions. So if you do use Alice.Router the __using__ macro just invokes use Alice.Handler. Then we deprecate that in 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Fixing this issue will require a breaking change enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamzaninovich @NateBarnes
0