This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Ensure Contiguous Hidden State Tensors in Encoders #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a small test to demonstrate that this works? It can go either here: Simply demonstrating that the wrapper can run forward when the input state is non-contiguous would be enough, nothing complicated! |
|
Test added to |
DeNeutoy
approved these changes
Jul 17, 2018
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
* doesn't ensure a contiguous tensor, causes runtime exception * adding test for robustness against non-contiguous input states
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index_select()doesn't ensure a contiguous tensor, which can cause a runtime exception since PyTorch RNNs require them to be .