8000
Shouldn't black and brightblack be swapped in iTerm2 theme ? · Issue #405 · altercation/solarized · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been struggling sometimes because my default iTerm2 colors are good, but I found myself having to fix the background or some other areas in emacs or vim because it was too bright compared to my default background color in iTerm. I had to specify "brightblack" instead of "black". Because in the iTerm2 theme, "brightblack" is the darkest color. And I realized that when it was working fine, that was when the specific color theme where using the default background color which by default is equal to "brightblack". But it was bad when they were using the keyword "black" directly.
I've investigated the issue and realized when switching color themes in iTerm that as far as "black/brightblack" is concerned, the Solarized theme is doing the opposite of pretty much every other color theme. In the others, the darkest one is "black" and that is the one used for background.
Shouldn't these 2 be swapped ?
I am only mentioning iTerm but maybe that is the overall trend. Maybe there is even a good reason behind it. I personally find it a bit annoying. I've spotted this while setting my tmux config, which in some places does not support "brightblack". The line "set -g status-fg brightblack" for example is failing on my system. It works in lines using a style string though.
Now that being said, I am sure it would be a major issue to change this so far down the line, but I'd like to know your take on this because it might change my point of view.
The text was updated successfully, but these errors were encountered:
mig-hub
changed the title
Shouldn't black and brightblack be swapped in iTerm2 config ?
Shouldn't black and brightblack be swapped in iTerm2 theme ?
Aug 4, 2020
Hello,
I have been struggling sometimes because my default iTerm2 colors are good, but I found myself having to fix the background or some other areas in emacs or vim because it was too bright compared to my default background color in iTerm. I had to specify "brightblack" instead of "black". Because in the iTerm2 theme, "brightblack" is the darkest color. And I realized that when it was working fine, that was when the specific color theme where using the default background color which by default is equal to "brightblack". But it was bad when they were using the keyword "black" directly.
I've investigated the issue and realized when switching color themes in iTerm that as far as "black/brightblack" is concerned, the Solarized theme is doing the opposite of pretty much every other color theme. In the others, the darkest one is "black" and that is the one used for background.
Shouldn't these 2 be swapped ?
I am only mentioning iTerm but maybe that is the overall trend. Maybe there is even a good reason behind it. I personally find it a bit annoying. I've spotted this while setting my tmux config, which in some places does not support "brightblack". The line "set -g status-fg brightblack" for example is failing on my system. It works in lines using a style string though.
Now that being said, I am sure it would be a major issue to change this so far down the line, but I'd like to know your take on this because it might change my point of view.
The text was updated successfully, but these errors were encountered: