8000 Ignored PR in changelog · Issue #309 · anchore/chronicle · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Ignored PR in changelog #309
Open
Open
@wagoodman

Description

@wagoodman

What happened:
When a PR closes an issue outside of the repo the accompanying PR is not included in the changelog:
anchore/stereoscope#382

The commit was considered:

[0000] DEBUG ├── de1c8e2565179839581b9c9fc91880be3a16f4ed

Linked to to a syft issue

[0001] TRACE PR #382 filtered out: has linked issue that is still open: issue 3683

Claims to have also filtered it out for label reasons:

[0001] TRACE PR #382 filtered out: has labels

What you expected to happen:
When a PR closes an issue outside of the repo the accompanying PR should be in the changelog.

Proposed fix: we should agnostically make certain that if we're filtering out a PR because it's linked to something that the issue in question that would take it's place is at least being considered (if not then we should keep it).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0