8000 [Suggestion] CallState: rename loaded to success · Issue #25 · angular-architects/ngrx-toolkit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Suggestion] CallState: rename loaded to success #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
the-ult opened this issue Mar 13, 2024 · 3 comments
Open

[Suggestion] CallState: rename loaded to success #25

the-ult opened this issue Mar 13, 2024 · 3 comments

Comments

@the-ult
Copy link
the-ult commented Mar 13, 2024

Could it be an idea to rename loaded to success or something like that?
Since the state of the response is successful. Otherwise it would be error. Correct?

If @rainerhahnekamp agrees, I could provide a PR with the proposed change

See: #23 (comment)
@rainerhahnekamp
Copy link
Collaborator

I'll have to bring @manfredsteyer in. He has ownership of the callstate extension.

@tizueh
Copy link
tizueh commented Aug 8, 2024

Would be great if this could be used only for loading data. That would be enable something similar as useTransition.

@rainerhahnekamp
Copy link
Collaborator

Well, to be honest, if you look at the issue, we can hardly process all of them. So i am very cautious when it comes to introduce breaking changes likes this. We can do it, but under 2 circumstances:

  • You should explain why we need it and what the advantage would be
  • You will have to implement it in a way, that we don't introduce breaking changes. So successful could be introduced via a configuration flag or a migration script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@the-ult @rainerhahnekamp @tizueh
0