8000 fix(Matomo): typings and number of dimensions by mistic100 · Pull Request #474 · angulartics/angulartics2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(Matomo): typings and number of dimensions #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix(Matomo): typings and number of dimensions #474

merged 1 commit into from
Aug 14, 2023

Conversation

mistic100
Copy link
Contributor
  • What kind of change does this PR introduce?

Fix typings for Matomo :

  • dimensions start form 1 and the maximum is 15 https://matomo.org/faq/reporting-tools/create-track-and-manage-custom-dimensions/
  • the value of eventTrack is actually optional (as seen in the implementation)
  • the current definition of setUserProperties prevents to define dimensions 
    this.setUserProperties({
    dimension1: this.appConfig.appCode,
});

    Argument of type '{ dimension1: string; }' is not assignable to parameter of type 'SetCustomVariableMatomoProperties'.
    Type '{ dimension1: string; }' is missing the following properties from type 'SetCustomVariableMatomoProperties': index, name, value, scope

@scttcper scttcper merged commit 0bd3d9e into angulartics:master Aug 14, 2023
@github-actions
Copy link

🎉 This PR is included in version 12.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mistic100
Copy link
Contributor Author

thanks

@mistic100 mistic100 deleted the matomo branch August 15, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistic100 @scttcper
0