Feature request: namespaced model methods #78

marckohlbrugge · 2024-10-29T14:47:45Z

Problem

My User model already has a subscribed? method indicating whether the user is a paying subscriber of my app.

Solution

Namespace all method with mailkick_ so we get methods like mailkick_subscribed?
Only define shorthand aliases (subscribed?, etc) if no such methods exists.

What do you think?

Code example

module Mailkick
  module Model
    def has_subscriptions
      class_eval do
        alias_method :subscriptions, :mailkick_subscriptions unless method_defined? :subscriptions
        alias_method :subscribe, :mailkick_subscribe unless method_defined? :subscribe
        alias_method :unsubscribe, :mailkick_unsubscribe unless method_defined? :unsubscribe
        alias_method :subscribed?, :mailkick_subscribed? unless method_defined? :subscribed? 
      
        has_many :mailkick_subscriptions, class_name: "Mailkick::Subscription", as: :subscriber
        scope :mailkick_subscribed, ->(list) { joins(:mailkick_subscriptions).where(mailkick_subscriptions: {list: list}) }

        def mailkick_subscribe(list)
          mailkick_subscriptions.where(list: list).first_or_create!
          nil
        end

        def mailkick_unsubscribe(list)
          mailkick_subscriptions.where(list: list).delete_all
          nil
        end

        def mailkick_subscribed?(list)
          mailkick_subscriptions.where(list: list).exists?
        end
      end
    end
  end
end

The text was updated successfully, but these errors were encountered:

marckohlbrugge · 2025-01-16T01:38:11Z

If there's interest, I'll make a PR

rromanchuk · 2025-05-02T00:53:03Z

@marckohlbrugge same, i have an existing has_many :subscriptions and makes me nervous

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature request: namespaced model methods #78

Feature request: namespaced model methods #78

Feature request: namespaced model methods #78

Feature request: namespaced model methods #78

Comments

Problem

Solution

Code example