8000 fail validate_role_spec plugin if argument_spec is undefined by trishnaguha · Pull Request #221 · ansible-network/network-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fail validate_role_spec plugin if argument_spec is undefined #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

fail validate_role_spec plugin if argument_spec is undefined #221

merged 1 commit into from
Feb 13, 2019

Conversation

trishnaguha
Copy link
Member
@trishnaguha trishnaguha commented Feb 13, 2019 •
edited
Loading

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

Fail validate_role_spec plugin if argument_spec is undefined in specification file.
With no argument_spec being defined AnsibleModule class doesn't run any validation for other conditions and fail.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@trishnaguha trishnaguha force-pushed the fail_if_no_argument_spec branch from ce935b3 to 058bd24 Compare February 13, 2019 04:52
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@trishnaguha
fail validate_role_spec plugin if argument_spec is undefined
7b5f5e6 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha force-pushed the fail_if_no_argument_spec branch from 058bd24 to 7b5f5e6 Compare February 13, 2019 05:13
@trishnaguha trishnaguha added the gate Gate PR in Zuul CI label Feb 13, 2019
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ae41c13 into ansible-network:devel Feb 13, 2019
@trishnaguha trishnaguha deleted the fail_if_no_argument_spec branch February 13, 2019 05:35
@trishnaguha
Copy link
Member Author

Backported to 2.6.10 #223

@trishnaguha trishnaguha mentioned this pull request Feb 20, 2019
Closed
@Qalthos Qalthos mentioned this pull request Feb 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@privateip privateip Awaiting requested review from privateip

@NilashishC NilashishC Awaiting requested review from NilashishC

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees
No one assigned
Labels
gate Gate PR in Zuul CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trishnaguha @ganeshrn
0