Defend against transactions that source nonce account addresses from lookup tables #309
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
solana-foundation/solana-improvement-documents#242 will make it impossible to load a nonce account from an address lookup table, so we must adjust the ergonomics of the JS SDK to prohibit creating such a transaction message.
Details
createAdvanceNonceAccountInstruction()does not produce anIAccountLookupMeta(already the case, I think)isAdvanceNonceAccountInstructionForNonce()must assert that the nonce account in anAdvanceNonceinstruction is not anIAccountLookupMetacompressTransactionMessageUsingAddressLookupTables()should refuse to convert anAdvanceNonceinstruction's nonce account from anIAccountMetato anIAccountLookupMeta. Note: this will be bad for package efficiency, because this will mean putting nonce-specific logic in a place where it will almost never be used. Think hard about whether this is worth it or not.getAddressMapFromInstructions()should always upgrade lookup table entries to static entries if they belong to a nonce account that is subject to anAdvanceNonceinstruction. Note: like 3, this will be bad for package efficiency, because this will mean putting nonce-specific logic into the message compiler where it will almost never be used. Think hard about whether this is worth it or not.Note
There is a world where, if we're OK with taking the hit on package efficiency to implement 4, then we can ignore all of the other changes. That is to say we can play fast and loose with whether we allow an
AdvanceNonceInstructionto contain anIAccountLookupMetaknowing that eventually the transaction message compiler will ‘upgrade’ it to a static entry. Thoughts?The text was updated successfully, but these errors were encountered: