8000 🐛 Bug Report: Duplicate verification users API entry. · Issue #5717 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Bug Report: Duplicate verification users API entry. #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
byawitz opened this issue Jun 16, 2023 · 1 comment · Fixed by #5918
Closed
2 tasks done

🐛 Bug Report: Duplicate verification users API entry. #5717

byawitz opened this issue Jun 16, 2023 · 1 comment · Fixed by #5918
Assignees
@stnguyen90 @joeyouss
Labels
backlog Issues waiting in the backlog bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Milestone
1.4.0

Comments

@byawitz
Copy link
Member
byawitz commented Jun 16, 2023 •
edited
Loading

👟 Reproduction steps

I'm not sure - maybe it is purposely - but I've noticed that the /v1/users/:userId/verification PATCH endpoint is written twice inside the file app/controllers/api/users.php.

  • First occurrence - Link
  • Second occurrence - Link

The only difference is the first version also includes, this line

    ->label('audits.userId', '{request.userId}')

👍 Expected behavior

To have just one, for easy maintaining process.

👎 Actual Behavior

There's two.

🎲 Appwrite version

Version 1.3.x

💻 Operating system

Linux

🧱 Your Environment

Edge version in Github.

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?
@byawitz byawitz added the bug Something isn't working label Jun 16, 2023
@joeyouss joeyouss self-assigned this Jun 19, 2023
@joeyouss
Copy link

Hey there,

Yes, we're aware of this. It seems like there's some leftover code that needs fixing, and it will be taken care of.

@stnguyen90 stnguyen90 mentioned this issue Jul 22, 2023
Merged
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
@joeyouss joeyouss added the backlog Issues waiting in the backlog label Jul 29, 2023
@stnguyen90 stnguyen90 added the product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. label Jul 31, 2023
@stnguyen90 stnguyen90 self-assigned this Jul 31, 2023
@stnguyen90 stnguyen90 added this to the 1.4.0 milestone Jul 31, 2023
@stnguyen90 stnguyen90 mentioned this issue Jul 31, 2023
Merged
2 tasks
@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stnguyen90 stnguyen90

@joeyouss joeyouss

Labels
backlog Issues waiting in the backlog bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Delete duplicate users endpoint appwrite/appwrite
3 participants
@byawitz @stnguyen90 @joeyouss
0