8000 🐛 Bug Report: Deleting deployment does not work for VCS deployments · Issue #6289 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Bug Report: Deleting deployment does not work for VCS deployments #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
JoshiJoshiJoshi opened this issue Sep 21, 2023 · 1 comment · Fixed by #6290
Closed
2 tasks done

🐛 Bug Report: Deleting deployment does not work for VCS deployments #6289

JoshiJoshiJoshi opened this issue Sep 21, 2023 · 1 comment · Fixed by #6290
Assignees
@stnguyen90
Labels
bug Something isn't working product / functions Fixes and upgrades for the Appwrite Functions.

Comments

@JoshiJoshiJoshi
Copy link

👟 Reproduction steps

  1. Setup S3 Storage (Digital Ocean Spaces)
  2. Deploy any function
  3. Go to that function and delete any deployments
  4. Deployment does not get deleted

Logs from worker-deletes:
Screenshot 2023-09-21 at 03 17 20@2x

👍 Expected behavior

Delete that specific deployment from storage

👎 Actual Behavior

It actually does not delete it

🎲 Appwrite version

Version 1.4.x

💻 Operating system

Linux

🧱 Your Environment

Version 1.4.3 Self hosted

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?
@JoshiJoshiJoshi JoshiJoshiJoshi added the bug Something isn't working label Sep 21, 2023
@JoshiJoshiJoshi JoshiJoshiJoshi changed the title 🐛 Bug Report: Deleting deployment won' 🐛 Bug Report: Deleting deployment does not work for S3 Storage Sep 21, 2023
@stnguyen90 stnguyen90 self-assigned this Sep 21, 2023
@stnguyen90 stnguyen90 moved this to In Progress in 1.4 release Sep 21, 2023
@stnguyen90
Copy link
Contributor

@JoshiJoshiJoshi, thanks for creating this issue! 🙏🏼 It looks like the deployment path is empty for VCS deployments and so the delete throws an exception and then doesn't finish deleting the build.

@stnguyen90 stnguyen90 added the product / functions Fixes and upgrades for the Appwrite Functions. label Sep 21, 2023
@stnguyen90 stnguyen90 changed the title 🐛 Bug Report: Deleting deployment does not work for S3 Storage 🐛 Bug Report: Deleting deployment does not work for VCS deployments Sep 21, 2023
@stnguyen90 stnguyen90 mentioned this issue Sep 21, 2023
Merged
2 tasks
@stnguyen90 stnguyen90 linked a pull request Sep 21, 2023 that will close this issue
Fix deployment delete #6290
Merged
2 tasks
@stnguyen90 stnguyen90 moved this from In Progress to Code Review in 1.4 release Sep 21, 2023
@github-project-automation github-project-automation bot moved this from Code Review to Done in 1.4 release Sep 22, 2023
This was referenced Oct 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stnguyen90 stnguyen90

Labels
bug Something isn't working product / functions Fixes and upgrades for the Appwrite Functions.
Projects
No open projects
1.4 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deployment delete appwrite/appwrite
2 participants
@stnguyen90 @JoshiJoshiJoshi
0