8000 🐛 Bug Report: Incorrect URL Format Gets Accepted on Document Creation · Issue #6372 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Bug Report: Incorrect URL Format Gets Accepted on Document Creation #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
noob8boi opened this issue Sep 30, 2023 · 6 comments
Open
2 tasks done

🐛 Bug Report: Incorrect URL Format Gets Accepted on Document Creation #6372

noob8boi opened this issue Sep 30, 2023 · 6 comments
Assignees
@stnguyen90
Labels
bug Something isn't working product / databases Fixes and upgrades for the Appwrite Database.

Comments

@noob8boi
Copy link
noob8boi commented Sep 30, 2023 •
edited
Loading

👟 Reproduction steps

  1. Create URL attribute in your collection.
  2. Input this value while creating the document :- https://i0.wp.com/anitrendz.net/news/wp-content/uploads/2023/09/★milet_Anytime-Anywhere_cover-art.jpg.
  3. Try to update the document. (Error)

👍 Expected behavior

It should have errored while creating the document.

👎 Actual Behavior

It lets me create the document and causes future problems while updating the document.

🎲 Appwrite version

Version 1.4.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?
@noob8boi noob8boi added the bug Something isn't working label Sep 30, 2023
@noob8boi
Copy link
Author

Weird I tried to reproduce but its not happening now ;--; .. maybe i am missing a step.

@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
@safwanyp
Copy link
Contributor
safwanyp commented Oct 1, 2023

@noob8boi Apart from the semantics of it, there is no real indication that the URL is malformed/invalid.

  • Starts with the protocol: https://
  • Then the hostname: i0.wp.com
  • Then the resource: /anitrendz.net/...

These are valid in terms of syntax (unless I'm missing something obvious), and wouldn't be flagged as invalid. You're probably be better off implementing a regex check before creating the document.

@noob8boi
Copy link
Author
noob8boi commented Oct 1, 2023

@noob8boi Apart from the semantics of it, there is no real indication that the URL is malformed/invalid.

  • Starts with the protocol: https://
  • Then the hostname: i0.wp.com
  • Then the resource: /anitrendz.net/...

These are valid in terms of syntax (unless I'm missing something obvious), and wouldn't be flagged as invalid. You're probably be better off implementing a regex check before creating the document.

I understand but the main problem is why it got created in the 1st place. I thought it was because of this ★ which can be solved by regex checking but since I am unable to reproduce I am not sure if that will be enough :/ .. Anyway I will post a reply if I find something. Thanks!

@safwanyp
Copy link
Contributor
safwanyp commented Oct 1, 2023

I understand but the main problem is why it got created in the 1st place. I thought it was because of this ★ which can be solved by regex checking but since I am unable to reproduce I am not sure if that will be enough :/ .. Anyway I will post a reply if I find something. Thanks!

That sounds good. Let me know!

@stnguyen90
Copy link
Contributor

@noob8boi have you been able to reproduce? Please be advised we'll need to close this soon due to inactivity.

@stnguyen90 stnguyen90 added the product / databases Fixes and upgrades for the Appwrite Database. label Oct 16, 2023
@stnguyen90 stnguyen90 self-assigned this Oct 16, 2023
@noob8boi
Copy link
Author

@noob8boi have you been able to reproduce? Please be advised we'll need to close this soon due to inactivity.

I wasn't able to. You can close it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stnguyen90 stnguyen90

Labels
bug Something isn't working product / databases Fixes and upgrades for the Appwrite Database.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stnguyen90 @safwanyp @noob8boi
0