8000 🐛 Bug Report: Push Notification for iOS badge is string, but should be number · Issue #8854 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 Bug Report: Push Notification for iOS badge is string, but should be number #8854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
docimin opened this issue Oct 24, 2024 · 11 comments · Fixed by #9060
Closed
2 tasks done

🐛 Bug Report: Push Notification for iOS badge is string, but should be number #8854

docimin opened this issue Oct 24, 2024 · 11 comments · Fixed by #9060
Assignees
Labels
bug Something isn't working good first issue Good for newcomers product / messaging Fixes and upgrades for the Appwrite Messaging.

Comments

@docimin
Copy link
docimin commented Oct 24, 2024

👟 Reproduction steps

This might be related to: #8601

👍 Expected behavior

Looking at the APNS docs, it should be a number instead.
https://developer.apple.com/documentation/usernotifications/generating-a-remote-notification#Payload-key-reference
Image

👎 Actual Behavior

In the Appwrite Docs you can see that the badge requires a string
Image

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

Windows

🧱 Your Environment

1.6.x - Cloud

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@docimin docimin added the bug Something isn't working label Oct 24, 2024
@DH-555 DH-555 added the product / messaging Fixes and upgrades for the Appwrite Messaging. label Oct 25, 2024
@elprogramadorgt
Copy link

Hello, i would like to help with this

@DH-555 DH-555 added the good first issue Good for newcomers label Oct 25, 2024
@DH-555
Copy link
Member
DH-555 commented Oct 25, 2024

@elprogramadorgt I assigned it to you. Make sure to test it and provide screenshots one finished 😄.

@elprogramadorgt
Copy link

Hello @DH-555 I fixed the issue, but I wasn't able to test it locally due to the connection with redis.

Can you help with that?

Also, I found some files like swagger2-1.6.x-server.json that have string for the badge, are those automatically generated? I'm asking because if not those need to change as well.

@DH-555
Copy link
Member
DH-555 commented Oct 26, 2024

@elprogramadorgt Sure. What problem do you have with the redis connection?

I'm not sure about the swagger files. Will check them.

@DH-555
Copy link
Member
DH-555 commented Oct 28, 2024

@elprogramadorgt It seems that the swagger files are being generated automatically, so you don't need to change them.

@elprogramadorgt
Copy link

Hello @DH-555, I was trying to run it locally with this command:

docker run -it --rm \
    --volume /var/run/docker.sock:/var/run/docker.sock \
    --volume "$(pwd)"/appwrite:/usr/src/code/appwrite:rw \
    --entrypoint="install" \
    appwrite/appwrite:1.6.0

but I got this error.

Image

Do you know how can I test it locally before pushing my PR?

@DH-555
Copy link
Member
DH-555 commented Nov 1, 2024

@elprogramadorgt Do you have run appwrite in that machine proveiously?
Maybe there is something from an old version that is causing that issue

@sri-c9
Copy link
sri-c9 commented Dec 1, 2024

Can I pick this issue up?

@stnguyen90 stnguyen90 linked a pull request Dec 4, 2024 that will close this issue
2 tasks
@stnguyen90
Copy link
Contributor

Unassigning due to inactivity. We'll be picking this up.

@stnguyen90 stnguyen90 moved this to Code Review in 1.6 Release Dec 31, 2024
@courreges-do
Copy link

Hi! Is this issue still open? I'd love to give it a try if no one is working on it.

@docimin
Copy link
Author
docimin commented Apr 23, 2025

@stnguyen90 this has been fixed in #9060 no?

@github-project-automation github-project-automation bot moved this from Code Review to Done in 1.6 Release May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers product / messaging Fixes and upgrades for the Appwrite Messaging.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants
0