🐛 Bug Report: SMTP username and password aren't validated when updating SMTP settings

👟 Reproduction steps

Update a project's SMTP settings
Use a valid host, port, and secure protocol, but an incorrect username and password
Click Update

👍 Expected behavior

The update should fail because the username and password are incorrect.

👎 Actual Behavior

The SMTP settings are updated successfully.

We use $mail->SmtpConnecti() test the connection:

appwrite/app/controllers/api/projects.php

Lines 1684 to 1695 in 8e02115

    
           $mail = new PHPMailer(true); 
        
           $mail->isSMTP(); 
        
           $mail->Username = $username; 
        
           $mail->Password = $password; 
        
           $mail->Host = $host; 
        
           $mail->Port = $port; 
        
           $mail->SMTPSecure = $secure; 
        
           $mail->SMTPAutoTLS = false; 
        
           $mail->Timeout = 5; 
        
           try { 
        
               $valid = $mail->SmtpConnect();

However, because SMTPAuth isn't set to true, the username and password are not checked.

We need to set SMTPAuth like we do in the worker:

appwrite/src/Appwrite/Platform/Workers/Mails.php

Line 166 in 8e02115

$mail->SMTPAuth = (!empty($username) && !empty($password));

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

I have read the Code of Conduct

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

👟 Reproduction steps

👍 Expected behavior

👎 Actual Behavior

🎲 Appwrite version

💻 Operating system

🧱 Your Environment

👀 Have you spent some time to check if this issue has been raised before?

🏢 Have you read the Code of Conduct?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	$mail = new PHPMailer(true);
	$mail->isSMTP();
	$mail->Username = $username;
	$mail->Password = $password;
	$mail->Host = $host;
	$mail->Port = $port;
	$mail->SMTPSecure = $secure;
	$mail->SMTPAutoTLS = false;
	$mail->Timeout = 5;

	try {
	$valid = $mail->SmtpConnect();

Description

👟 Reproduction steps

👍 Expected behavior

👎 Actual Behavior

🎲 Appwrite version

💻 Operating system

🧱 Your Environment

👀 Have you spent some time to check if this issue has been raised before?

🏢 Have you read the Code of Conduct?

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions