8000 Add Brotli support to Appwrite Nginx Server · Issue #310 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Brotli support to Appwrite Nginx Server #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eldadfux opened this issue Apr 13, 2020 · 13 comments
Closed

Add Brotli support to Appwrite Nginx Server #310

eldadfux opened this issue Apr 13, 2020 · 13 comments
Assignees
@eldadfux @Rohitub222 @W4nn4Die
Labels
enhancement New feature or request

Comments

@eldadfux
Copy link
Member

Brotli is a generic-purpose lossless compression algorithm that compresses data using a combination of a modern variant of the LZ77 algorithm, Huffman coding and 2nd order context modeling, with a compression ratio comparable to the best currently available general-purpose compression methods. It is similar in speed with deflate but offers more dense compression.
https://github.com/google/brotli

This integration should improve Appwrite HTTP performance on supported clients. Currently Traefik doesn't support this (traefik/traefik#6011) so our Nginx container is our only option.

This should be added on our main Dockerfile located here:
https://github.com/appwrite/appwrite/blob/master/Dockerfile
@eldadfux eldadfux added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 13, 2020
@Rohitub222
Copy link

Hi eldadfux, would love to work on this. Is anyone working on this? If not, want to do so.

@eldadfux
Copy link
Member Author

Hey @Rohitub222, no-one is working on this yet, it will be great if you could help with this.

You can also join our Discord channel if you'd like: https://discord.gg/GSeTUeA

Let me know if you need any help

@Rohitub222
Copy link

If I could be of any help to you then the pleasure is mine.
Thank you for letting me in.

@eldadfux
Copy link
Member Author

@Rohitub222 Any news? let me know if I can help

@Rohitub222
Copy link
Rohitub222 commented Apr 18, 2020 via email

@eldadfux
Copy link
Member Author

Thinking about it more, I think it would be better to go with Nginx for multiple reasons.

  • Traefik + Brotli has been in talk from 2018 and still not clear if this is actually going to happen.
  • Our Traefik server is completely decoupled from the app, while the nginx is very well aware and coupled to it. Nginx support will not introduce new complexity.
  • It probably be better to leave the hard workload to the Nginx (which acts as our http server) as it's always easier to scale the app server rather than the load balancer.
  • Even if Traefik will release support for this, it will take more time for it to be stable.

@Rohitub222
Copy link
Rohitub222 commented Apr 22, 2020 via email

@eldadfux
Copy link
Member Author
eldadfux commented May 3, 2020

Hey @Rohitub222 , any updates? let me know if you could use any help...

@Rohitub222
Copy link
Rohitub222 commented May 4, 2020 via email

@Rohitub222
Copy link
Rohitub222 commented May 10, 2020 via email

@christyjacob4
Copy link
Member

@Rohitub222 You can create a fork of the repo, push your changes to your fork and then raise a PR against the main repo

@eldadfux
Copy link
Member Author

Exactly what @christyjacob4 said ⏫👍

@eldadfux eldadfux mentioned this issue Jun 13, 2020
Merged
@eldadfux eldadfux added waiting for release Fixed or implemented and waiting for a new version to be released and removed work in progress good first issue Good for newcomers help wanted Extra attention is needed labels Jun 13, 2020
@eldadfux eldadfux mentioned this issue Oct 13, 2020
Merged
@eldadfux
Copy link
Member Author

Brotli compression is now available on Appwrite 0.7! Start boosting your APIs! Thanks to everyone who helped on this issue ❤️

@eldadfux eldadfux removed the waiting for release Fixed or implemented and waiting for a new version to be released label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eldadfux eldadfux

@Rohitub222 Rohitub222

@W4nn4Die W4nn4Die

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eldadfux @christyjacob4 @Rohitub222 @W4nn4Die
0