8000 Fix cross-project scheduler stability by Meldiron · Pull Request #8641 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix cross-project scheduler stability #8641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix cross-project scheduler stability #8641

merged 1 commit into from
Sep 10, 2024

Conversation

Meldiron
Copy link
Contributor
@Meldiron Meldiron commented Sep 7, 2024

What does this PR do?

Uses schedule doc internal ID as in-memory key of scheduler. This prevent issues with same resource ID across different projects.

Test Plan

No new tests; existing tests must pass

  • Manual QA; 2 projects (different IDs), 1 function in each (same function ID); scheduler every minute

Project 66dc8ecf00208a16edb8, function 66dc8ebb001477bdfcf0:
CleanShot 2024-09-07 at 19 40 05@2x

Project 66dc8eb30013a1a2f5e8, function 66dc8ebb001477bdfcf0:

CleanShot 2024-09-07 at 19 40 12@2x

^ Notice both have executions every minute, so scheduler works as expected for this scehario.

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 7, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 7, 2024

✨ Benchmark results

  • Requests per second: 1,628
  • Requests with 200 status code: 293,016
  • P99 latency: 0.079821131

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,628 1,754
200 293,016 315,725
P99 0.079821131 0.081644497

@christyjacob4 christyjacob4 merged commit e744a7e into 1.6.x Sep 10, 2024
25 checks passed
@christyjacob4 christyjacob4 deleted the fix-scheduler-across-projects branch September 10, 2024 10:23
@stnguyen90 stnguyen90 linked an issue Sep 16, 2024 that may be closed by this pull request
🐛 Bug Report: Schedules not working for functions with the same ID #8583
Closed
2 tasks
@stnguyen90 stnguyen90 changed the title Fix: cross-project scheduler stability Fix cross-project scheduler stability Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Schedules not working for functions with the same ID
2 participants
@Meldiron @christyjacob4
0