8000 Problem with the sortable control · Issue #1197 · themeum/kirki · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Problem with the sortable control #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas92 opened this issue Dec 10, 2016 · 4 comments
Closed

Problem with the sortable control #1197

nicolas92 opened this issue Dec 10, 2016 · 4 comments
Milestone
3.0

Comments

@nicolas92
Copy link

Issue description:

Hello @aristath, I noticed a small problem with WordPress 4.7 and the sortable control. The button to save the customizer changes is "Saved" and if you change an option, the button becomes "Save & Publish" but when I insert the sortable control, the button is original to "Save & Publish ", it is not a big problem because if I make changes and I click on the button, my changes are saved but if it is possible to solve this small problem, it would be great :) I tried with the latest version of kirki on wordpress and on github.

Version used:

stable 2.3.7 and I also test with the github version

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

Kirki::add_field( 'my_config', array(
	'type'        => 'sortable',
	'settings'    => 'my_setting',
	'label'       => __( 'This is the label', 'my_textdomain' ),
	'section'     => 'section_test',
	'default'     => array(
		'option3',
		'option1',
		'option4'
	),
	'choices'     => array(
		'option1' => esc_attr__( 'Option 1', 'kirki' ),
		'option2' => esc_attr__( 'Option 2', 'kirki' ),
		'option3' => esc_attr__( 'Option 3', 'kirki' ),
		'option4' => esc_attr__( 'Option 4', 'kirki' ),
		'option5' => esc_attr__( 'Option 5', 'kirki' ),
		'option6' => esc_attr__( 'Option 6', 'kirki' ),
	),
	'priority'    => 10,
) );
@aristath aristath mentioned this issue Dec 10, 2016
Closed
@aristath
Copy link
Contributor

Fixed in 8a2f674

@nicolas92
Copy link
Author

You are the best, thank you very much :)

@aristath
Copy link
Contributor
aristath commented Dec 11, 2016 •
edited
Loading

:) glad I could help.
Please note though that this fix is on the develop branch which may include other bugs as well since it's a rewrite of a lot of things... If you could test it and report any issues you find I'd greatly appreciate it! 👍

@nicolas92
Copy link
Author

You can count on me :)

@aristath aristath modified the milestone: 3.0 Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@aristath @nicolas92
0