8000 Import source and build for default stylesheet into this repository · Issue #4062 · asciidoctor/asciidoctor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Import source and build for default stylesheet into this repository #4062
Closed
@mojavelinux

Description

@mojavelinux

The default stylesheet (for the HTML output) is currently generated by the asciidoctor-stylesheet-factory project. However, that project uses a build which relies on unmaintained software. It's also arduous and obscure to have to make changes to files into another project and import the generated result into this repository to be committed. The whole process will be a lot simpler if that build is located in this project.

To avoid introducing unanticipated changes to the stylesheet, we'll need to work backwards from the minified/distributed end result until we get to something that's maintainable. This issue focuses on the first stage in that migration, which is described below:

  1. Unminify data/stylesheets/asciidoctor-default.css (this will become the editable source file)
    • The source file will be maintained in plain CSS with some help from PostCSS
  2. Set up and configure a npm-based build that uses postcss + cssnano to produce the same or similar minified result as before
  3. Use the build to generate data/stylesheets/asciidoctor-default.min.css
  4. Update the processor to read the default styles from the data/stylesheets/asciidoctor-default.min.css file instead of data/stylesheets/asciidoctor-default.css file
    • If this doesn't work out, the source file could be named data/styelsheets/asciidoctor-default.src.css instead
  5. Configure the gemspec to omit the stylesheet source file from the gem

We'll probably want to avoid committing the minified file to the repository and generating it on demand for the test suite and release, but we should do that in a later stage.

Metadata

Metadata

Assignees

Labels

infrastructureIssues related to infrastructure: CI, building, releasing, etc...v2.0.16Issues resolved in the 2.0.16 release

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0