-
Notifications
You must be signed in to change notification settings - Fork 1
Complexity of examples #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to o 8000 ur terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
To answer question in #48 (comment) @hyanwong it'd be nice to have examples that are relatively simple to read. I realize that your example grew out of an ongoing project though. The current state is great (thanks for finding lots of bugs/issues!) but adding a lot more code complexity to the PR /branch would make things hard to understand as an ftprime example. |
Yes, I agree about making them easy to read / simpler & not relying on external code. I feel a bit guilty about bloating the code. However, I do think it is worth having examples that can be called either as a python routine in their own right or as a |
Cool. Those are good comments and I agree separating code from main() is nice style. It's all a balancing act. |
Code to allow SFS-like testing of example files is at hyanwong@40d01ae Since it updates the SFS incrementally, you will need to pass it a function to calculate various statistics iteratively. I use a hacked together script which could probably do with some tidying, something like (untested)
|
Ideally we'll have a few stand-alone example scripts (eg as contributed by @hyanwong in #48 ) but these will:
The text was updated successfully, but these errors were encountered: