8000 [2.3] theme carousel storage path fix · Issue #10816 · bagisto/bagisto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
[2.3] theme carousel storage path fix #10816
Open
@krishanujadiya

Description

@krishanujadiya

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

v2.3.x-dev

Issue Description

packages/Webkul/Theme/src/Repositories/ThemeCustomizationRepository.php
Line 110
'image' => 'storage/'.$path,

Preconditions

PHP 8.4.8
Laravel 11.44.2

Steps to reproduce

  1. Enable S3 Disk Storage
  2. Open http://127.0.0.1:8000/admin/settings/themes/edit/1
  3. Add Carousel Image
  4. See error the storage path is not correct because hardcoded storage not Storage::url

Expected Result

The image path should get update according to filesystem disk.

Actual Result

Solution
'image' => Storage::url($path),

Screenshots

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0