8000 Improve input validation for missing configs (for new chains) · Issue #635 · balancer/b-sdk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve input validation for missing configs (for new chains) #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy stat 8000 ement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brunoguerios opened this issue Mar 31, 2025 · 0 comments · May be fixed by #680
Open

Improve input validation for missing configs (for new chains) #635

brunoguerios opened this issue Mar 31, 2025 · 0 comments · May be fixed by #680
Assignees
@mkflow27

Comments

@brunoguerios
Copy link
Member
brunoguerios commented Mar 31, 2025 •
edited
Loading

Input validation currently does not provide a good error message for missing configs (e.g. router addresses), which usually happens on chains that are yet not supported.

Context/Thoughts

  • We currently check if chain exists within chains list, but this is not a good enough check as is.
  • Do we need to enforce configs properly set for every chain in the chains list?
  • Should we be more explicit on which chains are supported? (e.g. on docs)
  • We should keep in mind that not everything is supported on all chains (e.g. nested operations are not supported for Balancer v3 on AVAX)
This was referenced May 2, 2025
Closed
Closed
Closed
@mkflow27 mkflow27 linked a pull request May 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkflow27 mkflow27

Labels
None yet
Projects
None yet
4951
Milestone
No milestone
2 participants
@brunoguerios @mkflow27
0