8000 third_party/protobuf/upstream is broken as of tags/v3.0.0-beta-1-bzl-fix~7 · Issue #13 · bazelment/trunk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

third_party/protobuf/upstream is broken as of tags/v3.0.0-beta-1-bzl-fix~7 8000 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smparkes opened this issue Feb 23, 2016 · 3 comments
Open

third_party/protobuf/upstream is broken as of tags/v3.0.0-beta-1-bzl-fix~7 #13

smparkes opened this issue Feb 23, 2016 · 3 comments

Comments

@smparkes
Copy link

Have you seen this? As of the commit in the description, this breaks bazel with a bunch of errors of the pattern

The package third_party/protobuf/upstream is not within the path google/protobuf/internal/descriptor_pool_test1_pb2.py.

This was a commit late last year and remains broken in master.

I don't know if this should be considered an error upstream in that it breaks using the repo as a "subrepo"?

Comments?
Suggestions?
@mzhaom
Copy link
Member
mzhaom commented Feb 25, 2016

The recent change in protobuf's BUILD made it impossible to use it as a submodule, instead we need to use git remote repository. I'll send out a fix soon. And patch is also welcome, :)

@smparkes
Copy link
Author

Ah. I'm relatively new to bazel so I'm cautious about stuff that might be my error.

But given hints, I can run. :-)

git remoting is fairly straightforward.

However, I ran into a sticking point in the java stuff, in the genrule for gen_well_known_protos_java, in particular " -Isrc $(SRCS) " in the cmd. protoc wants to know the prefix of the protos but when the protobuf repo is being used remotely, src isn't the whole prefix path, it's something like external/protobuf/src and protoc gets confused.

I haven't figured out a way to grab the prefix from the environment. Any hints on that?

@smparkes
Copy link
Author

protocolbuffers/protobuf#1278

As long as that lands, I can create the PR to use git_repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smparkes @mzhaom
0