Open
Description
Summary
First encountered in https://github.com/bitcoin/bitcoin/actions/runs/14929268797/job/41941137828?pr=31144
Doing a git bisect reveals the likely culprit is mining: bugfix: Fix duplicate coinbase tx weight reservation
Reproducer
git checkout 6b165f5
HEAD is now at 6b165f5906 Merge bitcoin/bitcoin#31384: mining: bugfix: Fix duplicate coinbase tx weight reservationcmake -B build -DCMAKE_BUILD_TYPE=Release && cmake --build build -j$(nproc) && build/test/functional/feature_fee_estimation.py --random=3450808900320758527
2025-05-09T14:55:06.412000Z TestFramework (INFO): User supplied random seed 3450808900320758527
2025-05-09T14:55:06.412000Z TestFramework (INFO): PRNG seed is: 3450808900320758527
2025-05-09T14:55:06.413000Z TestFramework (INFO): Initializing test directory /var/folders/5t/04gq0pqj5yv4t8cxw51q0s2m0000gn/T/bitcoin_func_test_wg3p8s0v
2025-05-09T14:55:06.426000Z TestFramework (INFO): This test is time consuming, please be patient
2025-05-09T14:55:06.426000Z TestFramework (INFO): Splitting inputs so we can generate tx's
2025-05-09T14:55:06.988000Z TestFramework (INFO): Finished splitting
2025-05-09T14:55:07.791000Z TestFramework (INFO): Testing estimates with single transactions.
2025-05-09T14:55:07.791000Z TestFramework (INFO): Will output estimates for 1/2/3/6/15/25 blocks
2025-05-09T14:55:07.791000Z TestFramework (INFO): Creating transactions and mining them with a block size that can't keep up
2025-05-09T14:55:09.501000Z TestFramework (INFO): Creating transactions and mining them at a block size that is just big enough
2025-05-09T14:55:11.955000Z TestFramework (INFO): Creating transactions and mining them with a block size that can't keep up
2025-05-09T14:55:14.407000Z TestFramework (INFO): Creating transactions and mining them at a block size that is just big enough
2025-05-09T14:55:17.271000Z TestFramework (INFO): Final estimates after emptying mempools
2025-05-09T14:55:17.287000Z TestFramework (INFO): Test fee_estimates.dat is flushed periodically
2025-05-09T14:55:18.131000Z TestFramework (INFO): Test fee rate estimation after restarting node with high MempoolMinFee
2025-05-09T14:55:18.523000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/Users/lorinc/IdeaProjects/bitcoin/test/functional/test_framework/test_framework.py", line 135, in main
self.run_test()
~~~~~~~~~~~~~^^
File "/Users/lorinc/IdeaProjects/bitcoin/build/test/functional/feature_fee_estimation.py", line 458, in run_test
self.test_feerate_mempoolminfee()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Users/lorinc/IdeaProjects/bitcoin/build/test/functional/feature_fee_estimation.py", line 243, in test_feerate_mempoolminfee
check_estimates(self.nodes[1], self.fees_per_kb)
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/lorinc/IdeaProjects/bitcoin/build/test/functional/feature_fee_estimation.py", line 121, in check_estimates
check_smart_estimates(node, fees_seen)
~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
File "/Users/lorinc/IdeaProjects/bitcoin/build/test/functional/feature_fee_estimation.py", line 104, in check_smart_estimates
raise AssertionError(
f"Estimated fee ({feerate}) out of range ({min(fees_seen)},{max(fees_seen)})"
)
AssertionError: Estimated fee (0.00923427) out of range (5.076142131979696e-05,0.008705986394557823)
2025-05-09T14:55:18.578000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2025-05-09T14:55:18.578000Z TestFramework (WARNING): Not cleaning up dir /var/folders/5t/04gq0pqj5yv4t8cxw51q0s2m0000gn/T/bitcoin_func_test_wg3p8s0v
2025-05-09T14:55:18.578000Z TestFramework (ERROR): Test failed. Test logging available at /var/folders/5t/04gq0pqj5yv4t8cxw51q0s2m0000gn/T/bitcoin_func_test_wg3p8s0v/test_framework.log
2025-05-09T14:55:18.579000Z TestFramework (ERROR):
2025-05-09T14:55:18.579000Z TestFramework (ERROR): Hint: Call /Users/lorinc/IdeaProjects/bitcoin/test/functional/combine_logs.py '/var/folders/5t/04gq0pqj5yv4t8cxw51q0s2m0000gn/T/bitcoin_func_test_wg3p8s0v' to consolidate all logs
2025-05-09T14:55:18.579000Z TestFramework (ERROR):
2025-05-09T14:55:18.579000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-05-09T14:55:18.579000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2025-05-09T14:55:18.579000Z TestFramework (ERROR):
[node 2] Cleaning up leftover process
[node 1] Cleaning up leftover process
[node 0] Cleaning up leftover processgit checkout HEAD^1
HEAD is now at 6a46be75c4 Merge bitcoin/bitcoin#31793: ci: Use clang-20 for sanitizer taskscmake -B build -DCMAKE_BUILD_TYPE=Release && cmake --build build -j$(nproc) && build/test/functional/feature_fee_estimation.py --random=3450808900320758527
2025-05-09T14:53:52.973000Z TestFramework (INFO): User supplied random seed 3450808900320758527
2025-05-09T14:53:52.973000Z TestFramework (INFO): PRNG seed is: 3450808900320758527
2025-05-09T14:53:52.974000Z TestFramework (INFO): Initializing test directory /var/folders/5t/04gq0pqj5yv4t8cxw51q0s2m0000gn/T/bitcoin_func_test_1dgb1kvc
2025-05-09T14:53:52.992000Z TestFramework (INFO): This test is time consuming, please be patient
2025-05-09T14:53:52.992000Z TestFramework (INFO): Splitting inputs so we can generate tx's
2025-05-09T14:53:53.560000Z TestFramework (INFO): Finished splitting
2025-05-09T14:53:54.423000Z TestFramework (INFO): Testing estimates with single transactions.
2025-05-09T14:53:54.423000Z TestFramework (INFO): Will output estimates for 1/2/3/6/15/25 blocks
2025-05-09T14:53:54.423000Z TestFramework (INFO): Creating transactions and mining them with a block size that can't keep up
2025-05-09T14:53:56.340000Z TestFramework (INFO): Creating transactions and mining them at a block size that is just big enough
2025-05-09T14:53:58.810000Z TestFramework (INFO): Creating transactions and mining them with a block size that can't keep up
2025-05-09T14:54:00.682000Z TestFramework (INFO): Creating transactions and mining them at a block size that is just big enough
2025-05-09T14:54:02.972000Z TestFramework (INFO): Final estimates after emptying mempools
2025-05-09T14:54:02.988000Z TestFramework (INFO): Test fee_estimates.dat is flushed periodically
2025-05-09T14:54:03.839000Z TestFramework (INFO): Test fee rate estimation after restarting node with high MempoolMinFee
2025-05-09T14:54:04.700000Z TestFramework (INFO): Test acceptstalefeeestimates option
2025-05-09T14:54:05.129000Z TestFramework (INFO): Test reading old fee_estimates.dat
2025-05-09T14:54:05.869000Z TestFramework (INFO): Restarting node with fresh estimation
2025-05-09T14:54:06.413000Z TestFramework (INFO): Testing estimates with RBF.
2025-05-09T14:54:08.411000Z TestFramework (INFO): Restarting node with fresh estimation
2025-05-09T14:54:09.016000Z TestFramework (INFO): Test estimatesmartfee modes
2025-05-09T14:54:27.128000Z TestFramework (INFO): Testing that fee estimation is disabled in blocksonly.
2025-05-09T14:54:27.607000Z TestFramework (INFO): Stopping nodes
2025-05-09T14:54:27.769000Z TestFramework (INFO): Cleaning up /var/folders/5t/04gq0pqj5yv4t8cxw51q0s2m0000gn/T/bitcoin_func_test_1dgb1kvc on exit
2025-05-09T14:54:27.769000Z TestFramework (INFO): Tests successful